Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount minikube volume to docker container #3261

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

zrdaley
Copy link
Contributor

@zrdaley zrdaley commented Oct 17, 2018

What this PR does / why we need it:
This was removed here: f2bfc42#diff-431621728cbbd3bf22d1c9ac24b0d761L72

However, mounting the minikube volume to the docker container is essential for e2e-tests to run properly. Failing to do so results in the following error:

Expected error:
      <clientcmd.errConfigurationInvalid | len:3, cap:4>: [
          {
              s: "unable to read client-cert $HOME/.minikube/client.crt for minikube due to open $HOME/.minikube/client.crt: no such file or directory",
          },
          {
              s: "unable to read client-key $HOME/.minikube/client.key for minikube due to open $HOME/.minikube/client.key: no such file or directory",
          },
          {
              s: "unable to read certificate-authority $HOME/.minikube/ca.crt for minikube due to open $HOME/.minikube/ca.crt: no such file or directory",
          },
      ]
      invalid configuration: [unable to read client-cert $HOME/.minikube/client.crt for minikube due to open $HOME/.minikube/client.crt: no such file or directory, unable to read client-key $HOME/.minikube/client.key for minikube due to open $HOME/.minikube/client.key: no such file or directory, unable to read certificate-authority $HOME/.minikube/ca.crt for minikube due to open $HOME/.minikube/ca.crt: no such file or directory]
  not to have occurred

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018
@aledbf
Copy link
Member

aledbf commented Oct 17, 2018

@zrdaley can you do this in a variable if the directory exists? (I removed the mount because it also breaks for those without minikube)

@diazjf
Copy link

diazjf commented Oct 18, 2018

This will help alot 👍

@zrdaley zrdaley force-pushed the minikube-cert-fix branch 3 times, most recently from 55b38a3 to f8f8ae6 Compare October 18, 2018 19:17
@diazjf
Copy link

diazjf commented Oct 19, 2018

Tested both positive and negative cases. Works Great!!

@aledbf
Copy link
Member

aledbf commented Oct 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, zrdaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@aledbf
Copy link
Member

aledbf commented Oct 19, 2018

@zrdaley thanks!

@aledbf
Copy link
Member

aledbf commented Oct 19, 2018

Merging.

@aledbf aledbf merged commit 99aff4a into kubernetes:master Oct 19, 2018
@zrdaley zrdaley deleted the minikube-cert-fix branch October 19, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants