Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for sticky lua module #2966

Merged
merged 4 commits into from
Aug 24, 2018
Merged

Add unit tests for sticky lua module #2966

merged 4 commits into from
Aug 24, 2018

Conversation

fmejia97
Copy link
Contributor

What this PR does / why we need it:
This PR adds unit tests for the sticky lua module. Why? We don't have any unit tests for this module.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2018
@fmejia97
Copy link
Contributor Author

Looking at the 2 tests that are failing after I rebased with upstream.

@fmejia97
Copy link
Contributor Author

Fixed tests. sticky_balancer_instance:balance() now returns ip and port as a single value. My tests were using the previous return values (ip, port).

@codecov-io
Copy link

codecov-io commented Aug 21, 2018 •
edited
Loading

Codecov Report

Merging #2966 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
- Coverage   47.58%   47.54%   -0.05%     
==========================================
  Files          77       77              
  Lines        5634     5639       +5     
==========================================
  Hits         2681     2681              
- Misses       2600     2605       +5     
  Partials      353      353
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.18% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a426fba...32426b9. Read the comment docs.

ElvinEfendi
ElvinEfendi reviewed Aug 21, 2018
View reviewed changes
rootfs/etc/nginx/lua/test/balancer/sticky_test.lua Outdated
end)
end)
end)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

ElvinEfendi
ElvinEfendi reviewed Aug 21, 2018
View reviewed changes
rootfs/etc/nginx/lua/test/balancer/sticky_test.lua Outdated
assert.equal(peer, test_backend_endpoint)
end)
end)
end)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 2 spaces for indentation

ElvinEfendi
ElvinEfendi reviewed Aug 21, 2018
View reviewed changes
rootfs/etc/nginx/lua/test/balancer/sticky_test.lua Outdated
local cookie = require("resty.cookie")
local util = require("util")

function get_mocked_ngx_env()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do the mocking similar to what's done at https://github.com/kubernetes/ingress-nginx/blob/master/rootfs/etc/nginx/lua/test/util_test.lua#L6 ?

eventually I'd like to extract that function into a test helper module, therefore it'd be better to be repeat consistently at least for now.

@ElvinEfendi
Copy link
Member

I'll look into the test coverage itself over the next twodays

@ElvinEfendi
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@fmejia97
Copy link
Contributor Author

@ElvinEfendi Addressed your comments.

@ElvinEfendi
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2018
@ElvinEfendi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, fmejia97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 72112fe into kubernetes:master Aug 24, 2018
@ElvinEfendi ElvinEfendi deleted the add-sticky-unit-tests branch October 12, 2018 17:39
@ElvinEfendi ElvinEfendi mentioned this pull request Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmejia97 @codecov-io @ElvinEfendi @k8s-ci-robot