Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve annotations/default_backend e2e test #2853

Merged
merged 1 commit into from
Jul 27, 2018
Merged

improve annotations/default_backend e2e test #2853

merged 1 commit into from
Jul 27, 2018

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Jul 27, 2018

What this PR does / why we need it:
Instead of asserting on Nginx config we now test by sending an actual request and asserting on expected response. This also makes sure the right headers are set for custom default backend.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
This PR is going to fix CI for #2794.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf
/assign @antoineco

@ElvinEfendi ElvinEfendi changed the title `improve annotations/default_backend e2e test improve annotations/default_backend e2e test Jul 27, 2018
@codecov-io
Copy link

Codecov Report

Merging #2853 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2853      +/-   ##
==========================================
- Coverage   47.39%   47.37%   -0.02%     
==========================================
  Files          75       75              
  Lines        5433     5433              
==========================================
- Hits         2575     2574       -1     
- Misses       2530     2532       +2     
+ Partials      328      327       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d263577...576baa8. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ElvinEfendi,antoineco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5cc185e into kubernetes:master Jul 27, 2018
@ElvinEfendi ElvinEfendi deleted the improve-e2e-test branch July 27, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants