Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve best-cert guessing with empty tls.hosts #2698

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Improve best-cert guessing with empty tls.hosts #2698

merged 1 commit into from
Jun 25, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Jun 24, 2018 •
edited
Loading

What this PR does / why we need it:

Literal host name comparison is insufficient to match wildcard certificates.

Which issue this PR fixes:

fixes #2667

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2018
@aledbf
Copy link
Member

aledbf commented Jun 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit e8a34d2 into kubernetes:master Jun 25, 2018
@antoineco antoineco deleted the bug/no-host-tls branch June 25, 2018 00:01
@aledbf aledbf mentioned this pull request Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wildcard certificate needs to specify every single domain
3 participants
@antoineco @aledbf @k8s-ci-robot