Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread cmd package and update flags description #2623

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Proofread cmd package and update flags description #2623

merged 1 commit into from
Jun 11, 2018

Conversation

antoineco
Copy link
Contributor

What this PR does / why we need it:

Originally part of #2368.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2018
@antoineco
Copy link
Contributor Author

/assign @aledbf
/assign @ElvinEfendi

@codecov-io
Copy link

Codecov Report

Merging #2623 into master will increase coverage by 0.2%.
The diff coverage is 76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2623     +/-   ##
=========================================
+ Coverage   40.68%   40.88%   +0.2%     
=========================================
  Files          75       75             
  Lines        5108     5129     +21     
=========================================
+ Hits         2078     2097     +19     
- Misses       2751     2753      +2     
  Partials      279      279
Impacted Files Coverage Δ
cmd/nginx/main.go 23.13% <13.04%> (-0.36%) ⬇️
cmd/nginx/flags.go 83.33% <94.8%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74d063...a74c34d. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2018
@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

@antoineco thanks!

@k8s-ci-robot k8s-ci-robot merged commit 238ad76 into kubernetes:master Jun 11, 2018
@antoineco antoineco deleted the improve-flags-doc branch June 11, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants