Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo about the kind of request #2517

Merged
merged 1 commit into from
May 16, 2018
Merged

Conversation

gmile
Copy link
Contributor

@gmile gmile commented May 16, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2018
@gmile
Copy link
Contributor Author

gmile commented May 16, 2018

Travis failure looks like a flack test?

• Failure [45.314 seconds]
[nginx-ingress] Dynamic Configuration
/home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:142
  should not fail requests when upstream-hash-by annotation is set [It]
  /home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/lua/dynamic_configuration.go:222
  Expected
      <string>: http-svc-5f5b96d78f-w7fnt
  not to equal
      <string>: http-svc-5f5b96d78f-w7fnt
  /home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/lua/dynamic_configuration.go:263
  Full Stack Trace
  	/home/travis/gopath/src/k8s.io/ingress-nginx/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:69 +0x1ed
  k8s.io/ingress-nginx/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).NotTo(0xc420295540, 0x1246fe0, 0xc42010cea0, 0x0, 0x0, 0x0, 0xc420295540)
  	/home/travis/gopath/src/k8s.io/ingress-nginx/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:43 +0xae
  k8s.io/ingress-nginx/test/e2e/lua.glob..func1.4()
  	/home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/lua/dynamic_configuration.go:263 +0x1a7f
  k8s.io/ingress-nginx/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc420098720, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	/home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/e2e.go:53 +0x172
  k8s.io/ingress-nginx/test/e2e.TestE2E(0xc4201c41e0)
  	/home/travis/gopath/src/k8s.io/ingress-nginx/test/e2e/e2e_test.go:36 +0x2b
  testing.tRunner(0xc4201c41e0, 0x11cbe80)
  	/home/travis/.gimme/versions/go1.10.1.linux.amd64/src/testing/testing.go:777 +0xd0
  created by testing.(*T).Run
  	/home/travis/.gimme/versions/go1.10.1.linux.amd64/src/testing/testing.go:824 +0x2e0```

@aledbf
Copy link
Member

aledbf commented May 16, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@aledbf
Copy link
Member

aledbf commented May 16, 2018

@gmile thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gmile

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2018
@ElvinEfendi
Copy link
Member

fwiw: yes, that's a flaky test - I'm expecting to tackle it sometime this week or next week unless someone else does. We have few other flaky tests as well.

@k8s-ci-robot k8s-ci-robot merged commit 2e53fa2 into kubernetes:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants