Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer configuration to external auth location config #2428

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Add buffer configuration to external auth location config #2428

merged 2 commits into from
Apr 26, 2018

Conversation

Eddman
Copy link
Contributor

@Eddman Eddman commented Apr 26, 2018

What this PR does / why we need it:
If the External Auth service returns for instance cookies that are bigger then 4Kb the request fails.

This happens whenever external auth service returns cookies and other headers that exceed the default proxy buffer (4Kb). The configmap option proxy-buffer-size is completely ignored and its proxy_buffer_size equivalent is not propagated to the auth location.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #2427

Special notes for your reviewer:
no

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2018
@aledbf
Copy link
Member

aledbf commented Apr 26, 2018

@Eddman please run make code-generator and push the changes

@aledbf aledbf self-assigned this Apr 26, 2018
@Eddman
Copy link
Contributor Author

Eddman commented Apr 26, 2018

@aledbf Done.

@codecov-io
Copy link

Codecov Report

Merging #2428 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2428      +/-   ##
==========================================
+ Coverage   40.91%   41.06%   +0.15%     
==========================================
  Files          74       74              
  Lines        5248     5248              
==========================================
+ Hits         2147     2155       +8     
+ Misses       2809     2801       -8     
  Partials      292      292
Impacted Files Coverage Δ
internal/file/bindata.go 60.17% <ø> (ø) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️
cmd/nginx/main.go 26.2% <0%> (+4.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad526b...89af4d6. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Apr 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2018
@aledbf
Copy link
Member

aledbf commented Apr 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Eddman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2018
@aledbf
Copy link
Member

aledbf commented Apr 26, 2018

@Eddman thanks!

@k8s-ci-robot k8s-ci-robot merged commit adffe74 into kubernetes:master Apr 26, 2018
@Eddman Eddman deleted the auth_proxy_buffer branch April 27, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Auth fails if the external auth service returns big headers
4 participants