Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx-opentracing to 0.3.0 #2411

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

SEJeff
Copy link
Contributor

@SEJeff SEJeff commented Apr 24, 2018

What this PR does / why we need it: Updates nginx-opentracing to 0.3.0

Special notes for your reviewer:
This version includes opentracing-contrib/nginx-opentracing#32 to add a http.host tag. This makes it easier to search in tracing backends which lack wildcard support such as zipkin or jaeger.

This version includes a new `http.host` header to make searching by
vhost in zipkin or jaeger more trivial.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2018
@SEJeff
Copy link
Contributor Author

SEJeff commented Apr 24, 2018

/assign @bprashanth

@SEJeff
Copy link
Contributor Author

SEJeff commented Apr 24, 2018

/assign @aledbf

@SEJeff
Copy link
Contributor Author

SEJeff commented Apr 24, 2018

/retest

@antoineco
Copy link
Contributor

antoineco commented Apr 24, 2018

The error is related to golang/lint#397 (there are ongoing hosting issues)

@aledbf
Copy link
Member

aledbf commented Apr 24, 2018

@SEJeff please rebase from master. The golint issue is fixed

@codecov-io
Copy link

Codecov Report

Merging #2411 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2411   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files          74       74           
  Lines        5252     5252           
=======================================
  Hits         2149     2149           
  Misses       2809     2809           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e1961...916ccf3. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Apr 24, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2018
@aledbf
Copy link
Member

aledbf commented Apr 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2018
@aledbf
Copy link
Member

aledbf commented Apr 24, 2018

@SEJeff thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, SEJeff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bb1d661 into kubernetes:master Apr 24, 2018
@SEJeff SEJeff deleted the update-opentracing-lib branch April 24, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants