Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated flag disable-node-list #2119

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Remove deprecated flag disable-node-list #2119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cmd/nginx/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ func parseFlags() (bool, *controller.Configuration, error) {
`Force namespace isolation. This flag is required to avoid the reference of secrets or
configmaps located in a different namespace than the specified in the flag --watch-namespace.`)

_ = flags.Bool("disable-node-list", false,
`Disable querying nodes. If --force-namespace-isolation is true, this should also be set. (DEPRECATED)`)

updateStatusOnShutdown = flags.Bool("update-status-on-shutdown", true, `Indicates if the
ingress controller should update the Ingress status IP/hostname when the controller
is being stopped. Default is true`)
Expand Down Expand Up @@ -132,8 +129,6 @@ func parseFlags() (bool, *controller.Configuration, error) {
`Define the sync frequency upper limit`)
)

flags.MarkDeprecated("disable-node-list", "This flag is currently no-op and will be deleted.")

flag.Set("logtostderr", "true")

flags.AddGoFlagSet(flag.CommandLine)
Expand Down