Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configmap option to disable IPv6 in nginx DNS resolver #1992

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

kinghrothgar
Copy link
Contributor

@kinghrothgar kinghrothgar commented Jan 26, 2018

What this PR does / why we need it:
Adds an option to disable IPv6 of nginx dns reslover

Which issue this PR fixes: fixes #1986

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 26, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 26, 2018
@aledbf
Copy link
Member

aledbf commented Jan 30, 2018

@kinghrothgar apologies, please rebase and we are ready to go.

@aledbf
Copy link
Member

aledbf commented Jan 31, 2018

@kinghrothgar please check the test failure (bad call to the buildResolvers function)

@aledbf
Copy link
Member

aledbf commented Feb 2, 2018

@kinghrothgar you need to update this test

resolver := buildResolvers(ipList)

@kinghrothgar
Copy link
Contributor Author

kinghrothgar commented Feb 2, 2018

Pushed that fix a few hours ago, waiting for the CI to finish.

@aledbf
Copy link
Member

aledbf commented Feb 2, 2018

@kinghrothgar please execute make code-generator and commit the changes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 39.802% when pulling cb848d8 on kinghrothgar:master into ad2238c on kubernetes:master.

@kinghrothgar
Copy link
Contributor Author

So the current CI fail seems to have nothing to do with code I touched or am I miss reading it?

@aledbf
Copy link
Member

aledbf commented Feb 2, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Feb 2, 2018

@kinghrothgar thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, kinghrothgar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2018
@aledbf aledbf merged commit 42076e8 into kubernetes:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildResolvers should not use IPv6 on hosts that do not support IPv6
5 participants