Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When upstream-hash-by annotation is used do not configure a lb algorithm #1858

Merged
merged 1 commit into from
Dec 27, 2017
Merged

When upstream-hash-by annotation is used do not configure a lb algorithm #1858

merged 1 commit into from
Dec 27, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 27, 2017

Which issue this PR fixes:

fixes #1490

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 27, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.764% when pulling f1d1ee9 on aledbf:hash-without-lb into 5c304cb on kubernetes:master.

@aledbf aledbf merged commit 54cfad0 into kubernetes:master Dec 27, 2017
@aledbf aledbf mentioned this pull request Dec 27, 2017
Closed
@aledbf aledbf deleted the hash-without-lb branch January 2, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot