Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about annotation values #1792

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Add note about annotation values #1792

merged 1 commit into from
Dec 3, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 3, 2017 •
edited
Loading

fixes #1783

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2017
@aledbf aledbf merged commit 5f8ab50 into kubernetes:master Dec 3, 2017
@aledbf aledbf deleted the annotation-types branch December 4, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numeric value to nginx.ingress.kubernetes.io/limit-rps does not work
3 participants
@aledbf @k8s-reviewable @k8s-ci-robot