Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable keep-alive requests to upstreams #1744

Closed
wants to merge 1 commit into from

Conversation

f84anton
Copy link

What this PR does / why we need it:
Set upstream proxy header "Connection: keep-alive" if upstream-keepalive-connections greater then 0 and we do not have Upgrade header in request.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #986

Special notes for your reviewer:

Release note:

NONE

Set proxy header "Connection: keep-alive" if upstream-keepalive-connections greater then 0.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.141% when pulling 9a21482 on f84anton:patch-1 into dcf4a45 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Nov 23, 2017

@f84anton please add an e2e test for this scenario

@f84anton
Copy link
Author

@aledbf, what kind of test? To make sure that connection to upstream send with Connection: keep-alive? I'm not familiar with e2e tests and I have weak golang skill. Need more hints.

@aledbf
Copy link
Member

aledbf commented Nov 23, 2017

@f84anton please check https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/defaultbackend/default_backend.go
and https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/annotations/alias.go
Basically you need to check the new code is generated in the nginx.conf and make some requests with aseertions (like searching in the headers the keepalived value)

@aledbf
Copy link
Member

aledbf commented Jan 19, 2018

I think we need a "connection" annotation to just allow to override the Connection header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overrule Connection header to upstream
5 participants