Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use merge of annotations #1687

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Fix use merge of annotations #1687

merged 1 commit into from
Nov 11, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 11, 2017

What this PR does / why we need it:

The library mergo do not overwrites value by default (breaking change introduced in latest version)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 42dad7f on aledbf:fix-merge into ** on kubernetes:master**.

@aledbf aledbf merged commit c64e9ae into kubernetes:master Nov 11, 2017
@aledbf aledbf deleted the fix-merge branch November 12, 2017 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants