Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GenericController and add tests #1648

Merged
merged 4 commits into from
Nov 5, 2017
Merged

Remove GenericController and add tests #1648

merged 4 commits into from
Nov 5, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 5, 2017

What this PR does / why we need it:

Cleanup and improve some the tests

@aledbf aledbf added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. enhancement labels Nov 5, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf changed the title Remove GenericController and add tests WIP: Remove GenericController and add tests Nov 5, 2017
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2017
@kubernetes kubernetes deleted a comment from coveralls Nov 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 36.381% when pulling 9fbd1f0cf2dddc06934130f773a52a61278b0dbe on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 36.364% when pulling 441f7a527c4902fb8c17cbce5f6b34f2811427da on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 36.377% when pulling 441f7a527c4902fb8c17cbce5f6b34f2811427da on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 36.715% when pulling 86f39d9 on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 36.513% when pulling 8656fc1 on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 36.513% when pulling 311d286 on aledbf:refactor-main into 1701bfc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 36.372% when pulling e2b74db on aledbf:refactor-main into 1701bfc on kubernetes:master.

@aledbf aledbf changed the title WIP: Remove GenericController and add tests Remove GenericController and add tests Nov 5, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2017
@aledbf aledbf merged commit 5e05acd into kubernetes:master Nov 5, 2017
@aledbf aledbf deleted the refactor-main branch November 5, 2017 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot