Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for nginx-ingress #1329

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Conversation

hzxuzhonghu
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 43.63% when pulling 8637e864a731f1430eadd16d48c4e9e54d02b9a4 on hzxuzhonghu:example into 7b4d8cb on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 9, 2017

@hzxuzhonghu please use a Deployment

@hzxuzhonghu
Copy link
Member Author

ok

@hzxuzhonghu
Copy link
Member Author

@aledbf Done, replace rc with deployment.

@aledbf aledbf self-assigned this Sep 11, 2017
@aledbf
Copy link
Member

aledbf commented Sep 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2017
@aledbf
Copy link
Member

aledbf commented Sep 11, 2017

@hzxuzhonghu thanks!

@aledbf aledbf merged commit 18ea2f7 into kubernetes:master Sep 11, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.976% when pulling 4481b2e on hzxuzhonghu:example into 1e943c0 on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants