Adds a log warning when falling back to default fake cert

kubernetes · Mar 29, 2019 · 2390205 · 2390205
1 parent 7e21a2d
commit 2390205
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/internal/ingress/controller/controller.go b/internal/ingress/controller/controller.go
@@ -866,10 +866,14 @@ func (n *NGINXController) createServers(data []*ingress.Ingress,
 	defaultPemSHA := n.cfg.FakeCertificateSHA
 
 	// read custom default SSL certificate, fall back to generated default certificate
-	defaultCertificate, err := n.store.GetLocalSSLCert(n.cfg.DefaultSSLCertificate)
-	if err == nil {
-		defaultPemFileName = defaultCertificate.PemFileName
-		defaultPemSHA = defaultCertificate.PemSHA
+	if n.cfg.DefaultSSLCertificate != "" {
+		defaultCertificate, err := n.store.GetLocalSSLCert(n.cfg.DefaultSSLCertificate)
+		if err == nil {
+			defaultPemFileName = defaultCertificate.PemFileName
+			defaultPemSHA = defaultCertificate.PemSHA
+		} else {
+			klog.Warningf("Error loading custom default certificate, falling back to generated default:\n%v", err)
+		}
 	}
 
 	// initialize default server and root location