-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "main struct" with methods #304
Conversation
4d0ae33
to
05740fc
Compare
05740fc
to
eed21d1
Compare
Start the process of encapsulating most of the flags and not using them as global variables. This commit JUST does the git command flag, which is now only accessed from main()
This commit encapsulates the root parameter. This exposed a bug where we do not reset the root of the workspace.
This commit encapsulates the repo parameter.
This commit encapsulates the branch and rev parameters.
This commit encapsulates the depth parameter.
This commit encapsulates the submodules parameter.
This commit encapsulates the chmod and link parameters.
This commit encapsulates the authURL parameter.
eed21d1
to
c410bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor. Thanks for splitting it up into the separated commits. Fascinating to move through each individually.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Broken down by commit for easier reviewing. This uncovered at least one real bug. This is building to some deeper code re-organization.
Builds on #300, #302, and #303