Add a "main struct" with methods #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
thockin
force-pushed
the
5-main-struct
branch
from
4d0ae33
to
05740fc
Compare
k8s-ci-robot
added
size/L
thockin
force-pushed
the
5-main-struct
branch
from
05740fc
to
eed21d1
Compare
Start the process of encapsulating most of the flags and not using them as global variables. This commit JUST does the git command flag, which is now only accessed from main()
This commit encapsulates the root parameter. This exposed a bug where we do not reset the root of the workspace.
This commit encapsulates the repo parameter.
This commit encapsulates the branch and rev parameters.
This commit encapsulates the depth parameter.
This commit encapsulates the submodules parameter.
This commit encapsulates the chmod and link parameters.
This commit encapsulates the authURL parameter.
thockin
force-pushed
the
5-main-struct
branch
from
eed21d1
to
c410bb5
Compare
stp-ip
approved these changes
Nov 13, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken down by commit for easier reviewing. This uncovered at least one real bug. This is building to some deeper code re-organization.
Builds on #300, #302, and #303