Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI: logging, stats, and more #552

Closed
yujuhong opened this issue Feb 5, 2018 · 24 comments
Closed

CRI: logging, stats, and more #552

yujuhong opened this issue Feb 5, 2018 · 24 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@yujuhong
Copy link
Contributor

yujuhong commented Feb 5, 2018

Feature Description

  • One-line feature description (can be used as a release note): Continue improving CRI in various aspects to better support non-docker runtimes.
  • Primary contact (assignee): @yujuhong
  • Responsible SIGs: sig-node
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @Random-Liu, @mrunalp
  • Approver (likely from SIG/area to which feature belongs): @dchen1107
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)
@idvoretskyi
Copy link
Member

@yujuhong @dchen1107 @kubernetes/sig-node-feature-requests do you already have a defined roadmap for this feature? Any plans for 1.11?

cc @justaugustus

@justaugustus
Copy link
Member

/assign @yujuhong

@yujuhong yujuhong added this to the v1.11 milestone Apr 23, 2018
@yujuhong
Copy link
Contributor Author

@idvoretskyi we plan to promote kubelet's log rotation feature from Alpha to Beta in 1.11.

Also, we plan to redefine the container logging path to ensure necessary metadata is captured.

@idvoretskyi
Copy link
Member

@yujuhong perfect, thanks!

@justaugustus justaugustus added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 24, 2018
@justaugustus
Copy link
Member

@yujuhong --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@kacole2
Copy link

kacole2 commented Jul 23, 2018

@yujuhong This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12. This still has the beta tag as well so we need to update it accordingly.

Please update the feature target milestones on your original post as well.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus justaugustus removed this from the v1.11 milestone Jul 31, 2018
@derekwaynecarr
Copy link
Member

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

@derekwaynecarr derekwaynecarr added this to the v1.12 milestone Jul 31, 2018
@kacole2
Copy link

kacole2 commented Aug 1, 2018

@derekwaynecarr thanks. Does this need to be tracked? Are there plans to introduce this as an alpha, beta. or GA feature in 1.12?

@justaugustus
Copy link
Member

@yujuhong @derekwaynecarr -- just to clarify, will this feature be graduating to Beta in 1.12 or is it already Beta? Also, can you update the feature targets in the issue description?

@zparnold
Copy link
Member

Hey there! @yujuhong I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@yujuhong
Copy link
Contributor Author

This doesn't need to be tracked by an umbrella issue anymore.

@yujuhong yujuhong reopened this Aug 20, 2018
@justaugustus
Copy link
Member

@yujuhong -- I'm unsure of why this feature was closed. The feature targets are incomplete and updates have not been provided, so it's unclear where we stand.

Per @derekwaynecarr's comment (#552 (comment)):

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

Please provide more clarity before we decide whether or not this should be closed.

/reopen

@k8s-ci-robot
Copy link
Contributor

@justaugustus: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

@yujuhong -- I'm unsure of why this feature was closed. The feature targets are incomplete and updates have not been provided, so it's unclear where we stand.

Per @derekwaynecarr's comment (#552 (comment)):

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

Please provide more clarity before we decide whether or not this should be closed.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus reopened this Aug 21, 2018
@zparnold
Copy link
Member

@yujuhong Can you update me on the docs status when you have a sec?

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 5, 2018
@justaugustus
Copy link
Member

@yujuhong @dchen1107 --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@yujuhong
Copy link
Contributor Author

yujuhong commented Sep 5, 2018

We've discussed this and there will be no new change in 1.12. No documentation is needed.

@yujuhong yujuhong closed this as completed Sep 5, 2018
@tpepper
Copy link
Member

tpepper commented Sep 6, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Sep 6, 2018
@justaugustus
Copy link
Member

@yujuhong -- to my previous note (#552 (comment)), no one has clarified WHY this tracking feature should be closed.

Even if work is not planned for 1.12, the feature has yet to be graduated to GA, so it needs to remain open.

Please don't close this again until we have clarification on this.

cc: @derekwaynecarr @Random-Liu @mrunalp @dchen1107

@justaugustus justaugustus reopened this Sep 6, 2018
@justaugustus justaugustus added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 6, 2018
@kacole2
Copy link

kacole2 commented Oct 8, 2018

Hi @yujuhong
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Feb 1, 2020

Documentation issue: kubernetes/website#14956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

10 participants