KEP-4743: Kubernetes-etcd interface #4744
Conversation
|
@serathius: GitHub didn't allow me to request PR reviews from the following users: dead2k. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/kep
| * **Improved Testability:** Enable thorough testing of etcd and Kubernetes | ||
| interactions through a well-defined interface, as envisioned in [#15820]. | ||
| * **Error Prevention:** Reduce incorrect contract usage, addressing issues like Kubernetes [#110210]. | ||
| * **Reviewable Changes:** Make contract modifications easily reviewable and trackable, ensuring a transparent and collaborative evolution. |
There was a problem hiding this comment.
Can we call out backward compatibility here directly? I realize it's implied in work like this, but it gets a bit more interesting with SIG-etcd's proposals to introduce feature introspection and progressive enhancements.
There was a problem hiding this comment.
The etcd-kubernetes interface is just part of etcd client SDK. Regarding comparability, it's about the compatibility between etcd client sdk and etcdserver. So it isn't the scope of this KEP?
There was a problem hiding this comment.
@jpbetz Can you clarify your comment? Do you mean backward compatibility of the interface or backward compatibility of how K8s uses etcd or something else?
There was a problem hiding this comment.
Backward compatibility between k8s and etcd is my main concern. How the kubernetes-etcd interface facilitates that is what I'm hoping to see more details about in this document.
| * **Improved Testability:** Enable thorough testing of etcd and Kubernetes | ||
| interactions through a well-defined interface, as envisioned in [#15820]. | ||
| * **Error Prevention:** Reduce incorrect contract usage, addressing issues like Kubernetes [#110210]. | ||
| * **Reviewable Changes:** Make contract modifications easily reviewable and trackable, ensuring a transparent and collaborative evolution. |
There was a problem hiding this comment.
The etcd-kubernetes interface is just part of etcd client SDK. Regarding comparability, it's about the compatibility between etcd client sdk and etcdserver. So it isn't the scope of this KEP?
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
There was a problem hiding this comment.
Is this KEP the kind that is tied to a release, or the kind that isn't?
There was a problem hiding this comment.
No, etcd KEPs are not tied to release.
k8s-ci-robot
removed
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
serathius
force-pushed
the
kep4743
branch
2 times, most recently
from
6446f4b
to
ae7a369
Compare
|
/lgtm Thanks |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@serathius 2 tiny nits, but looks great overall! thanks. |
k8s-ci-robot
removed
the
lgtm
|
/lgtm @jpbetz - PTAL |
k8s-ci-robot
added
the
lgtm
One-line PR description: Moving https://docs.google.com/document/d/1-nIpoW87qqQ9FxINOzXPkhu7CD_FWW1piYqHZDr39nU/edit?usp=sharing to KEP
Issue link: Kubernetes-etcd interface #4743
Other comments:
/cc @ahrtr @wojtek-t @dims @jpbetz @deads2k