-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4580: Update KEP status to implementable #4736
KEP-4580: Update KEP status to implementable #4736
Conversation
HirazawaUi
commented
Jun 17, 2024
•
edited
Loading
edited
- One-line PR description: Update KEP status to implementable
- Issue link: Deprecate & remove Kubelet RunOnce mode #4580
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HirazawaUi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @dchen1107 @mrunalp |
17ea99f
to
c1788c5
Compare
c1788c5
to
89b310a
Compare
ping @dchen1107 @mrunalp @soltysh |
cc @tallclair |
@@ -155,7 +155,7 @@ Deprecate and remove kubelet support for RunOnce mode, and mark the `RunOnce` fi | |||
|
|||
## Motivation | |||
|
|||
* RunOnce does not work in systemd mode. | |||
* RunOnce mode has been broken and is no longer works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, it's just completely broken now? Do we know when it broke?
If it's just completely broken, I don't think we need to go through the whole deprecation dance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to have completely stopped working in kubernetes/kubernetes#90377, because the cpuManager is not initialized in runonce, when calling activePods() will cause nil pointer and kubelet panic. The milestone of kubernetes/kubernetes#90377 is v1.19....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @dchen1107 @mrunalp
Based on this, do you think we need to go through the whole deprecation dance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case we can just delete it straight ahead. 1.19 is reasonably old version to assume that anybody using it would have reported back the issue
89b310a
to
8fb1cf3
Compare
8fb1cf3
to
19444d6
Compare
/close |
@HirazawaUi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |