Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4580: Update KEP status to implementable #4736

Closed
wants to merge 1 commit into from
Closed

KEP-4580: Update KEP status to implementable #4736

wants to merge 1 commit into from

Conversation

HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Jun 17, 2024 •
edited

  • One-line PR description: Update KEP status to implementable
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HirazawaUi
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@HirazawaUi
Copy link
Contributor Author

/cc @dchen1107 @mrunalp

@sftim sftim mentioned this pull request Jun 23, 2024
Closed
@HirazawaUi HirazawaUi mentioned this pull request Jun 23, 2024
Closed
@HirazawaUi HirazawaUi force-pushed the psuh-runonce-to-implementable branch from 17ea99f to c1788c5 Compare June 23, 2024 16:42
@HirazawaUi HirazawaUi mentioned this pull request Jun 23, 2024
Closed
6 tasks
@HirazawaUi HirazawaUi force-pushed the psuh-runonce-to-implementable branch from c1788c5 to 89b310a Compare June 27, 2024 16:42
@HirazawaUi
Copy link
Contributor Author

ping @dchen1107 @mrunalp @soltysh

@aojea
Copy link
Member

aojea commented Jul 18, 2024

cc @tallclair

tallclair
tallclair reviewed Jul 20, 2024
View reviewed changes
keps/sig-node/4580-deprecate-kubelet-runonce/README.md Outdated
@@ -155,7 +155,7 @@ Deprecate and remove kubelet support for RunOnce mode, and mark the `RunOnce` fi

## Motivation

* RunOnce does not work in systemd mode.
* RunOnce mode has been broken and is no longer works.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, it's just completely broken now? Do we know when it broke?

If it's just completely broken, I don't think we need to go through the whole deprecation dance.

Copy link
Contributor Author

@HirazawaUi HirazawaUi Jul 20, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to have completely stopped working in kubernetes/kubernetes#90377, because the cpuManager is not initialized in runonce, when calling activePods() will cause nil pointer and kubelet panic. The milestone of kubernetes/kubernetes#90377 is v1.19....

ref: kubernetes/kubernetes#124030 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @dchen1107 @mrunalp
Based on this, do you think we need to go through the whole deprecation dance？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case we can just delete it straight ahead. 1.19 is reasonably old version to assume that anybody using it would have reported back the issue

@HirazawaUi HirazawaUi force-pushed the psuh-runonce-to-implementable branch from 89b310a to 8fb1cf3 Compare July 20, 2024 14:50
@HirazawaUi HirazawaUi force-pushed the psuh-runonce-to-implementable branch from 8fb1cf3 to 19444d6 Compare July 22, 2024 14:12
@HirazawaUi
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HirazawaUi HirazawaUi mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@bart0sh bart0sh bart0sh left review comments

@tallclair tallclair tallclair left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HirazawaUi @k8s-ci-robot @aojea @SergeyKanzhelev @bart0sh @tallclair