-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4322: add CRD scope explanation to alternatives considered section #4690
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
590002b
to
097dedd
Compare
f8f52da
to
319807d
Compare
7173a0a
to
4828031
Compare
/retest |
1 similar comment
/retest |
/lgtm |
@ryanzhang-oss: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve @mikemorris this needs |
Ah, #4749 hasn’t been merged, so /lgtm |
/assign @JeremyOT |
faffbf7
to
c6ced19
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikemorris, ryanzhang-oss, skitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Summarizes context from discussions in SIG-Multicluster meetings and https://docs.google.com/document/d/1E_z3ti-d-modwnhsvR3yBZwX4rRpL26dKkl41YAptRo/edit on why a namespace-scoped CRD is recommended over a cluster-scoped CRD for the ClusterProfile resource.
Thanks to @thockin for putting together these illustrations of the possible models for cluster inventory topology.