Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 1645: clarify the chosen conflict resolution algorithm #4683

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP 1645: clarify the chosen conflict resolution algorithm #4683

wants to merge 1 commit into from

Conversation

MrFreezeex
Copy link
Member

  • One-line PR description: This PR attempt to explain the reasons why the resolution algorithm was chosen by considering other conflict resolution algorithm in the alternatives sections and explaining why those were not selected.
  • Other comments: I tried to consider some other approaches based on what was discussed on the sig-multicluster meeting the 2024/04/30. However as this decision was made several years ago and I tried to fill the gap and imagine the reasons why those alternatives approach were not chosen, those reasons could not fully reflect what was brought up during this KEP original design. So if you remember some other reasons from that time (or any other reasons why we would not want to chose those) feel free to chime in!

@MrFreezeex
KEP 1645: clarify the chosen conflict resolution algorithm
ec3670b 
This PR attempt to explain the reasons why the resolution algorithm was
chosen by considering other conflict resolution algorithm in the
alternatives sections and explaining why those were not selected.

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2024
@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2024
@thockin
Copy link
Member

thockin commented Jun 7, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex, thockin
Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@JeremyOT JeremyOT

@thockin thockin

@lauralorenz lauralorenz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrFreezeex @thockin @k8s-ci-robot @JeremyOT @lauralorenz