Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2837: Introducing Pod level resource specifications with criteria for alpha phase #4678

Merged
merged 9 commits into from
Oct 9, 2024
Merged

KEP-2837: Introducing Pod level resource specifications with criteria for alpha phase #4678

merged 9 commits into from
Oct 9, 2024

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented May 31, 2024 •
edited
Loading

  • One-line PR description: KEP 2837 focuses on initial design to support pod level resources specification in alpha in 1.32

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp May 31, 2024 18:10
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2024
@ndixita ndixita force-pushed the master branch 12 times, most recently from 217b643 to 5376ed4 Compare June 1, 2024 01:42
@ndixita
Copy link
Contributor Author

ndixita commented Jun 1, 2024

/assign @thockin

@ndixita ndixita force-pushed the master branch 2 times, most recently from 94948ac to 8224bed Compare June 3, 2024 17:42
@ndixita ndixita marked this pull request as ready for review June 3, 2024 17:58
@marquiz marquiz mentioned this pull request Oct 8, 2024
Open
alculquicondor
alculquicondor reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any concerns from the scheduling perspective, so:
/approve
from SIG Scheduling

keps/sig-node/2837-pod-level-resource-spec/kep.yaml Show resolved Hide resolved
@thockin
Copy link
Member

thockin commented Oct 8, 2024

/approve

... for API

/lgtm

... for KEP overall

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@ndixita
Updating PRR
6785db3 
Signed-off-by: ndixita <ndixita@google.com>
@ndixita
Updating CA caveat
7ee5ff1 
Signed-off-by: ndixita <ndixita@google.com>
@ndixita
Updating PRR
32e84bc 
Signed-off-by: ndixita <ndixita@google.com>
@ndixita
Changing the language for resource usage by containers in a pod with …
5e04f14 
…no limits

Signed-off-by: ndixita <ndixita@google.com>
@ndixita
Updating non goals
6bb4c35 
Signed-off-by: ndixita <ndixita@google.com>
jpbetz
jpbetz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dchen1107, jpbetz, ndixita, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong
Copy link
Contributor

yujuhong commented Oct 9, 2024

/lgtm

As a SIG-Node KEP reviewer

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 962867f into kubernetes:master Oct 9, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 9, 2024
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
keps/sig-node/2837-pod-level-resource-spec/README.md
* Documentation mentioning high level design.


#### Phase 2: Beta (target 1.32)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so things like cpu manager, limit ranger, etc. are not part of beta graduation criteria? Or those are in alpha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for all features that are scoped out of alpha phase in the KEP design includes CPU manager.

There's a section for Limit Ranger in alpha.

@ndixita ndixita mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@adrianmoisey adrianmoisey adrianmoisey left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@thockin thockin thockin left review comments

@dchen1107 dchen1107 dchen1107 left review comments

@haircommander haircommander haircommander left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@yujuhong yujuhong yujuhong left review comments

@kerthcet kerthcet kerthcet left review comments

@tallclair tallclair tallclair left review comments

@iholder101 iholder101 iholder101 left review comments

@jpbetz jpbetz jpbetz approved these changes

Assignees

@jpbetz jpbetz

@thockin thockin

@dchen1107 dchen1107

@haircommander haircommander

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.