KEP-4578: Server Feature Gate in etcd #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siyuanfoundation
commented
May 2, 2024
siyuanfoundation
commented
- One-line PR description: KEP to introduce feature gate in etcd
- Issue link: Server Feature Gate in etcd #4578
- Other comments:
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
sig/etcd
|
/sig etcd cc @serathius @ahrtr @logicalhan @jmhbnz @fuweid @stackbaek @henrybear327 @wenjiaswe |
siyuanfoundation
force-pushed
the
etcd
branch
8 times, most recently
from
5e3a2db
to
9e23e71
Compare
jmhbnz
reviewed
May 4, 2024
sftim
reviewed
May 7, 2024
ahrtr
reviewed
May 7, 2024
ahrtr
reviewed
May 7, 2024
ahrtr
reviewed
May 7, 2024
siyuanfoundation
force-pushed
the
etcd
branch
6 times, most recently
from
f229b14
to
e621249
Compare
ahrtr
reviewed
May 13, 2024
serathius
reviewed
May 15, 2024
serathius
reviewed
Jun 3, 2024
serathius
reviewed
Jun 3, 2024
serathius
reviewed
Jun 3, 2024
siyuanfoundation
force-pushed
the
etcd
branch
3 times, most recently
from
d281e40
to
161b03d
Compare
serathius
reviewed
Jun 6, 2024
serathius
reviewed
Jun 6, 2024
serathius
reviewed
Jun 6, 2024
serathius
reviewed
Jun 6, 2024
| * the new feature would need to be enabled by default to always apply the bug fix for new releases. | ||
| * it changes the API which is not desirable in patch version releases. | ||
|
|
||
| The proper way of handling these bug fixes should be: |
There was a problem hiding this comment.
I like this, but we should get some feedback from K8s folks. cc @wojtek-t @logicalhan
serathius
approved these changes
Jun 6, 2024
k8s-ci-robot
added
the
approved
|
Some small nits, but overall proposal looks good to me. |
serathius
reviewed
Jun 6, 2024
Comment on lines
+12
to
+13
| - "@jmhbnz" | ||
| - "@wenjiaswe" | ||
| - "@fuweid" | ||
| - "@logicalhan" |
There was a problem hiding this comment.
That's a lot of reviewers, no need to have so many people, but if you want to keep it please make sure that you got review from everyone listed.
There was a problem hiding this comment.
ok. I'll try to get their reviews.
serathius
reviewed
Jun 6, 2024
Signed-off-by: Siyuan Zhang <sizhang@google.com>
|
/lgtm thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ahrtr
reviewed
Jun 8, 2024
Comment on lines
+242
to
+243
| | Alpha | Same as [Kubernetes feature stages - Alpha feature](https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-stages): <ul><li>Disabled by default. </li><li>Might be buggy. Enabling the feature may expose bugs. </li><li>Support for feature may be dropped at any time without notice. </li><li>The API may change in incompatible ways in a later software release without notice. </li><li>Recommended for use only in short-lived testing clusters, due to increased risk of bugs and lack of long-term support.</li></ul> | Before moving a feature to Beta, it should have <ul><li> Full unit/integration/e2e/robustness test coverage.</li><li>Full performance benchmark/test if applicable.</li><li> No significant changes for at least 1 minor release.</li></ul> | | ||
| | Beta | Same as [Kubernetes feature stages - Beta feature](https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-stages) except etcd Beta feature does not allow incompatible schema change: <ul><li>Enabled by default. </li><li>The feature is well tested. Enabling the feature is considered safe.</li><li>Support for the overall feature will not be dropped, though details may change.</li><li>Recommended for only non-business-critical uses because of potential for discovering new hard-to-spot bugs through wider adoption.</li></ul> | Before moving a feature to GA, it should have <ul><li> Widespread usage.</li><li>No bug reported for at least 1 minor release.</li></ul> | |
There was a problem hiding this comment.
Minor comment:
- For Alpha -> Beta, should add Criteria:
No unresolved major bugs. - For Beta -> GA, update criteria:
No major bug reported for at least 1 minor release
Note they are just minimal Graduation Criteria.
|
Overall looks good to me. Thanks @siyuanfoundation for driving the effort. |
|
LGTM. Thanks @siyuanfoundation ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.