Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3461: Add QoS Resource Manager to Extend Resource Allocation Policies #3465

Closed

Conversation

waynepeking348
Copy link

@waynepeking348 waynepeking348 commented Aug 16, 2022

  • KEP-3461: Add QoS Resource Manager to Extend Resource Allocation Policies
  • One-line PR description: Add a new component in Kubelet ecosystem to dynamically adjust resource allocation with more flexibility and extensibility, to support QoS-aware and Topology-aware systems

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: waynepeking348 / name: shaowei (eebdbf6)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @waynepeking348!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @waynepeking348. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: waynepeking348
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval by writing /assign @dchen1107 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 16, 2022
@waynepeking348 waynepeking348 changed the title KEP-3461: add kep for qos resource manager in kubelet KEP-3461: Add QoS Resource Manager to Extend Resource Allocation Policies Aug 16, 2022
@vinaykul vinaykul removed their assignment Aug 20, 2022
@vinaykul
Copy link
Member

/cc @vinaykul

@k8s-ci-robot
Copy link
Contributor

@vinaykul: GitHub didn't allow me to request PR reviews from the following users: vinaykul.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vinaykul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@klueska
Copy link
Contributor

klueska commented Aug 22, 2022

With the recently accepted KEP linked below, general resource management is moving towards a more dynamic model going forward. One will no longer be limited to providing a simple "count" of their resources. Driver implementors will be able to express the interface for requesting a set of resources however they like. There are already plans for writing drivers for CPU and Hugepages in this new framework (in addition to the plethora of other devices likes GPUs, NICs, etc.).

#3064

Can you comment on how this proposal plans to integrate / interoperate with this new model?

@waynepeking348
Copy link
Author

With the recently accepted KEP linked below, general resource management is moving towards a more dynamic model going forward. One will no longer be limited to providing a simple "count" of their resources. Driver implementors will be able to express the interface for requesting a set of resources however they like. There are already plans for writing drivers for CPU and Hugepages in this new framework (in addition to the plethora of other devices likes GPUs, NICs, etc.).

#3064

Can you comment on how this proposal plans to integrate / interoperate with this new model?

thx~ we read the detailed KEP as well as the alpha pr for DRA, those two KEP have a lot in similarity indeed, but we still got some got a few questions

  • we notice that DRA works as a topology manager hint provider, but it seems that DRA manager actually don't provide numa-affinity info for now, and the DRA plugin protocol doesn't contain numa-related info in Response either; we would like to what's the detailed plan for this functionality
  • you mentioned that you plan to writing drivers for CPU and Hugepages in DRA framework, and but we don't know how you plan to do this in detail, since the native scheduler already counts on Native Resources (cpu, memory, etc.) as predicated and prioritized inputs.
  • for now, only CDI can be injected in annotation for CRI, but if we want to set OCI Property for container (for instance, cpuset.mems, and so on), will it be extensible?
  • will you plan to support reconciling logic in DRA manager? since in real production environment, we may need to adjust resource allocation results periodically based on running states (instead of static allocation only)

@kikisdeliveryservice
Copy link
Member

@waynepeking348 As a reminder (and as noted on your issue) we generally ask that you discuss your KEP idea with the sponsoring sig prior to opening a PR in this repo. You did not include a Discussion Link in your issue. Please either provide one on the issue or contact sig node via their meetings/slack/mailing lists etc... to discuss your idea.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
csfldf added a commit to kubewharf/kubernetes that referenced this pull request Dec 19, 2022
…source allocation in admission phase and enable dynamic resource allocation adjustment for pods with better flexibility.

refer: kubernetes/enhancements#3465
csfldf added a commit to kubewharf/kubernetes that referenced this pull request Dec 19, 2022
…source allocation in admission phase and enable dynamic resource allocation adjustment for pods with better flexibility

refer: kubernetes/enhancements#3465
@bart0sh
Copy link
Contributor

bart0sh commented Dec 23, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2022
@k8s-ci-robot
Copy link
Contributor

@waynepeking348: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-enhancements-test eebdbf6 link true /test pull-enhancements-test
pull-enhancements-verify eebdbf6 link true /test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 22, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants