-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3329 Add KEP for Retriable and non-retriable Pod failures for Jobs #3374
KEP-3329 Add KEP for Retriable and non-retriable Pod failures for Jobs #3374
Conversation
mimowo
commented
Jun 9, 2022
- One-line PR description: Extend semantics of handling failed pods
- Issue link: Retriable and non-retriable Pod failures for Jobs #3329
- Other comments:
Welcome @mimowo! |
Hi @mimowo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7c35133
to
2e1fa76
Compare
/ok-to-test |
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/kep.yaml
Outdated
Show resolved
Hide resolved
d9da419
to
4649974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
using my SIG scheduling hat
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
/remove-sig node |
/assign @soltysh @johnbelamaric |
a2020e9
to
2fc30d2
Compare
Just came to this KEP to review and realized the scope is narrowed. Looks like the SIG Node / Kubelet dependencies are removed for alpha phase after the scope is changed. This is a useful feature and the decision is fine with me. Please come to SIG Node earlier next time to discuss the enhancement if needed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting SIG apps approval, then I can give the PRR approval.
4b60e2e
to
9b9836c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
for sig-apps pov
keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
Outdated
Show resolved
Hide resolved
9b9836c
to
24eee16
Compare
24eee16
to
aa8af12
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, johnbelamaric, mimowo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |