Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3329 Add KEP for Retriable and non-retriable Pod failures for Jobs #3374

Merged

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jun 9, 2022

  • One-line PR description: Extend semantics of handling failed pods
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mimowo!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mimowo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kow3ns June 9, 2022 13:53
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot requested a review from soltysh June 9, 2022 13:53
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 9, 2022
@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch 3 times, most recently from 7c35133 to 2e1fa76 Compare June 9, 2022 15:23
@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch 11 times, most recently from d9da419 to 4649974 Compare June 13, 2022 12:00
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
using my SIG scheduling hat

@mimowo
Copy link
Contributor Author

mimowo commented Jun 22, 2022

/remove-sig node
We do not modify kubelet in Alpha. It will be re-evaluated for Beta

@k8s-ci-robot k8s-ci-robot removed the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 22, 2022
@mimowo
Copy link
Contributor Author

mimowo commented Jun 22, 2022

/assign @soltysh @johnbelamaric

@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch from a2020e9 to 2fc30d2 Compare June 22, 2022 21:11
@dchen1107
Copy link
Member

Just came to this KEP to review and realized the scope is narrowed. Looks like the SIG Node / Kubelet dependencies are removed for alpha phase after the scope is changed. This is a useful feature and the decision is fine with me. Please come to SIG Node earlier next time to discuss the enhancement if needed. Thanks!

Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting SIG apps approval, then I can give the PRR approval.

@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch from 4b60e2e to 9b9836c Compare June 23, 2022 09:37
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
for sig-apps pov

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch from 9b9836c to 24eee16 Compare June 23, 2022 11:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@mimowo mimowo force-pushed the 3329-write-kep-for-retriable-exit-codes branch from 24eee16 to aa8af12 Compare June 23, 2022 11:42
@soltysh
Copy link
Contributor

soltysh commented Jun 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, johnbelamaric, mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58d3f83 into kubernetes:master Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 23, 2022
@liggitt liggitt removed their assignment Jul 29, 2022
@liggitt liggitt removed the api-review Categorizes an issue or PR as actively needing an API review. label Jul 29, 2022
@mimowo mimowo deleted the 3329-write-kep-for-retriable-exit-codes branch March 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.