Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSR test plan #1536

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Update CSR test plan #1536

merged 1 commit into from
Feb 3, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 31, 2020

Adds a test plan to the CSR KEP

/cc @mikedanese
fyi @jeremyrickard

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2020
@liggitt
Copy link
Member Author

liggitt commented Jan 31, 2020

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 31, 2020
@liggitt liggitt mentioned this pull request Jan 31, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
deads2k
deads2k reviewed Feb 3, 2020
View reviewed changes
keps/sig-auth/20190607-certificates-api.md Outdated
- e2e (and conformance, once v1) tests of:
- CSR API presence, basic crud behavior
- status subresource
- approval flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval as general concept isn't owned by kubernetes. Neither is signing. An e2e test for what we ship makes a lot of sense. I'm less convinced that non-kube owned code should have conformance tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scoped to a custom signerName, to ensure the mechanics work as designed and are usable by other approvers/signers

@deads2k
Copy link
Contributor

deads2k commented Feb 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 678aae6 into kubernetes:master Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 3, 2020
@liggitt liggitt deleted the csr-test branch April 15, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @deads2k @k8s-ci-robot