update kubeadm phases kep to support upgrade #1298

Klaven · 2019-10-11T12:41:36Z

This update to the kubeadm phases kep is to add support for phases in the kubeadm upgrade apply workflow.

issues resolved by this:
kubernetes/kubeadm#1318
kubernetes/kubeadm#1756

I also updated the KEP to document the kubeadm upgrade node phases workflow.

yagonobre

Thanks, Klaven!
In general SGTM!

yagonobre · 2019-10-11T14:16:30Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

+- As a kubernetes administrator/IT automation tool, I used kubeadm init/join and
+  excluded some phases, I want to run all the phases of kubeadm upgrade except
+  for some phases.


Maybe

- As a kubernetes administrator/IT automation tool, I want to run only one or some phases of the `kubeadm upgrade` workflow.

We should probably emphasize, that these phases are usually equivalent to the ones already excluded during init/join.

yagonobre · 2019-10-11T14:16:40Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

@@ -74,7 +74,8 @@ duplication of code or in some case inconsistencies between the init and phase i
 - This proposal doesn't include a plan for implementation of phases in workflows
  different than the `kubeadm init` workflow; such plans will be defined by the sig 
  during release planning for each cycle, and then documented in this KEP.
-  - v1.14 implementation of phases in the `kubeadm join` workflow (planned)
+  - v1.14 implementation of phases in the `kubeadm join` workflow
+  - v1.17 implementation of phases in the `kubeadm upgrade apply/plan/node` workflow


Maybe just kubeadm upgrade [1]

@yagonobre 👍 I did it this way because really it is the sub commands... but not all of them because I was looking at diff and am not sure it would apply... But if everyone is fine with just kubeadm upgrade that sounds good to me.

Make senses, I don't have a hard opinion, at least from me it's up to you.

I'll wait and see if others say anything. I too don't have a hard opinion :)

Let's narrow it down to kubeadm upgrade apply for 1.17. node already has phases and plan can be seen as a sub-set of apply (they go together).

yagonobre · 2019-10-11T14:18:20Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

@@ -110,15 +114,15 @@ own, nested, ordered sequence of phases. For instance:
 ````

 The above list of ordered phases should be made accessible from all the command supporting phases
-via the command help, e.g. `kubeadm init --help` (and eventually in the future `kubeadm join --help` etc.)
+via the command help, e.g. `kubeadm init --help` (and eventually in the future `kubeadm join --help` and `kubeadm upgrade apply/plan/node --help` etc.)


yagonobre · 2019-10-11T14:18:23Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md


 Additionally we are going to improve consistency between the command outputs/logs with the name of phases
 defined in the above list. This will be achieved by enforcing that the prefix of each output/log should match
 the name of the corresponding phase, e.g. `[certs/ca] Generated ca certificate and key.` instead of the current
 `[certificates] Generated ca certificate and key.`.

 Single phases will be made accessible to the users via a new `phase` sub command that will be nested in the
-command supporting phases, e.g. `kubeadm init phase` (and eventually in the future `kubeadm join phase` etc.). e.g.
+command supporting phases, e.g. `kubeadm init phase` and `kubeadm join phase` (and eventually in the future `kubeadm upgrade apply/plan/node phase` etc.). e.g.


yagonobre · 2019-10-11T14:18:29Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

@@ -152,7 +156,8 @@ workflows e.g. reuse of phase `certs` in both `kubeadm init` and `kubeadm join`
 * [#61631](https://github.com/kubernetes/kubernetes/pull/61631) First prototype implementation 
  (now outdated)
 * v1.13 implementation of phases in the `kubeadm init` workflow
-* v1.14 implementation of phases in the `kubeadm join` workflow (planned)
+* v1.14 implementation of phases in the `kubeadm join` workflow 
+* v1.17 implementation of phases in the `kubeadm upgrade apply/plan/node` workflow (planned)


v1.17 is kubeadm upgrade apply/plan. kubeadm upgrade node was done in one of the previous cycles (although I can't remember which one).

rosti

Thanks @Klaven !
Looks good for a start. Only minor nits.

rosti · 2019-10-14T13:51:05Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

@@ -74,7 +74,8 @@ duplication of code or in some case inconsistencies between the init and phase i
 - This proposal doesn't include a plan for implementation of phases in workflows
  different than the `kubeadm init` workflow; such plans will be defined by the sig 
  during release planning for each cycle, and then documented in this KEP.
-  - v1.14 implementation of phases in the `kubeadm join` workflow (planned)
+  - v1.14 implementation of phases in the `kubeadm join` workflow
+  - v1.17 implementation of phases in the `kubeadm upgrade apply/plan/node` workflow


Let's narrow it down to kubeadm upgrade apply for 1.17. node already has phases and plan can be seen as a sub-set of apply (they go together).

rosti · 2019-10-14T13:52:34Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

+- As a kubernetes administrator/IT automation tool, I used kubeadm init/join and
+  excluded some phases, I want to run all the phases of kubeadm upgrade except
+  for some phases.


We should probably emphasize, that these phases are usually equivalent to the ones already excluded during init/join.

rosti · 2019-10-14T13:55:34Z

keps/sig-cluster-lifecycle/kubeadm/0029-20180918-kubeadm-phases-beta.md

@@ -152,7 +156,8 @@ workflows e.g. reuse of phase `certs` in both `kubeadm init` and `kubeadm join`
 * [#61631](https://github.com/kubernetes/kubernetes/pull/61631) First prototype implementation 
  (now outdated)
 * v1.13 implementation of phases in the `kubeadm init` workflow
-* v1.14 implementation of phases in the `kubeadm join` workflow (planned)
+* v1.14 implementation of phases in the `kubeadm join` workflow 
+* v1.17 implementation of phases in the `kubeadm upgrade apply/plan/node` workflow (planned)


v1.17 is kubeadm upgrade apply/plan. kubeadm upgrade node was done in one of the previous cycles (although I can't remember which one).

neolit123 · 2019-10-14T19:26:16Z

/lgtm
/assign @timothysc

timothysc

/approve

k8s-ci-robot · 2019-10-14T19:51:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Klaven, neolit123, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/sig-cluster-lifecycle/OWNERS~~ [timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2019

k8s-ci-robot requested review from justinsb and timothysc October 11, 2019 12:41

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 11, 2019

yagonobre reviewed Oct 11, 2019

View reviewed changes

rosti reviewed Oct 14, 2019

View reviewed changes

update kubeadm phases kep to support upgrade

3ae91ed

Klaven force-pushed the phases_update branch from 148f4f2 to 3ae91ed Compare October 14, 2019 17:03

k8s-ci-robot assigned timothysc and neolit123 Oct 14, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019

timothysc approved these changes Oct 14, 2019

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019

k8s-ci-robot merged commit 857967b into kubernetes:master Oct 14, 2019

k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019

neolit123 mentioned this pull request Mar 1, 2021

kubeadm upgrade apply phases kubernetes/kubeadm#1318

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update kubeadm phases kep to support upgrade #1298

update kubeadm phases kep to support upgrade #1298

Klaven commented Oct 11, 2019 •

edited

Loading

yagonobre left a comment

yagonobre Oct 11, 2019

rosti Oct 14, 2019

Klaven Oct 14, 2019

yagonobre Oct 11, 2019

Klaven Oct 11, 2019

yagonobre Oct 11, 2019

Klaven Oct 11, 2019

rosti Oct 14, 2019

yagonobre Oct 11, 2019

yagonobre Oct 11, 2019

yagonobre Oct 11, 2019

rosti Oct 14, 2019

rosti left a comment

rosti Oct 14, 2019

rosti Oct 14, 2019

rosti Oct 14, 2019

neolit123 commented Oct 14, 2019

timothysc left a comment

k8s-ci-robot commented Oct 14, 2019

update kubeadm phases kep to support upgrade #1298

update kubeadm phases kep to support upgrade #1298

Conversation

Klaven commented Oct 11, 2019 • edited Loading

yagonobre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rosti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented Oct 14, 2019

timothysc left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 14, 2019

Klaven commented Oct 11, 2019 •

edited

Loading