Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce finalizerProbe for the pods like we have livenessProbe #4757

Open
4 tasks
bitsmaestro opened this issue Jul 11, 2024 · 6 comments
Open
4 tasks

Introduce finalizerProbe for the pods like we have livenessProbe #4757

bitsmaestro opened this issue Jul 11, 2024 · 6 comments
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@bitsmaestro
Copy link

bitsmaestro commented Jul 11, 2024

Enhancement Description

Requirement: while deleting a pod API server is not sure if anything on that pod is running or not. May be pod is still processing response for some rest call and we may loose it.

Enhancement: So suggestion is introduce an finalizerProbe which when curled should return if Pod is ready to die or not.
this should only be used when we get some external delete with force option, all other deletion scenarios should not care about finalizerProbe

finalizerProbe should return 500 if not ready to be deleted & 200 when ready to be deleted

Application inside the pod should ensure the logic to return return 500 or 200 as per the business
that new request is not accepted once a finalizerProbe is called or metadata.deletionTimestamp is added to the pod.

  • One-line enhancement description (can be used as a release note): Introduce finalizerProbe for the pods like we have livenessProbe
  • Kubernetes Enhancement Proposal:
  • Discussion Link:
  • Primary contact (assignee):
  • Responsible SIGs: app
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 11, 2024
@bitsmaestro
Copy link
Author

/sig app

@k8s-ci-robot
Copy link
Contributor

@bitsmaestro: The label(s) sig/app cannot be applied, because the repository doesn't have them.

In response to this:

/sig app

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitsmaestro
Copy link
Author

/sig app

@k8s-ci-robot
Copy link
Contributor

@bitsmaestro: The label(s) sig/app cannot be applied, because the repository doesn't have them.

In response to this:

/sig app

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitsmaestro
Copy link
Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2024
@bitsmaestro
Copy link
Author

Like HTTP we can implement similar concept for TCP probes and GRPC Health Checking Protocol also
error returned by finalizerProbe we dont delete the pod , success we delete the pod
it will be amalgamation of finalizers & probes concept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
Status: Needs Triage
Development

No branches or pull requests

2 participants