Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Health Status to the Pod Status for Device Plugin and DRA #4680

Open
3 of 4 tasks
SergeyKanzhelev opened this issue May 31, 2024 · 17 comments
Open
3 of 4 tasks
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented May 31, 2024

Enhancement Description

/sig node

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@SergeyKanzhelev
Copy link
Member Author

Discussed with @mrunalp and we fine to add this to milestone:

/milestone v1.31
/label lead-opted-in
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 31, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 31, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 31, 2024
@ArkaSaha30
Copy link
Member

Hello, @SergeyKanzhelev 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we would need to update the following:

  • Attach the PR link for the KEP with the relevant details along with PRR and get it merged

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jpbetz
Copy link
Contributor

jpbetz commented Jun 11, 2024

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

@SergeyKanzhelev
Copy link
Member Author

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

Yes, we have polished some imlpementation details, but from PRR perspective it is very straightforward

@richabanker
Copy link
Contributor

Looks like this is the KEP PR: #4681

@SergeyKanzhelev
Copy link
Member Author

@ArkaSaha30 this KEP can be marked as done for all the checkboxes you listed. Thank you!

@dipesh-rawat
Copy link
Member

Hello @SergeyKanzhelev 👋, 1.31 Enhancements team here,

Now that PR #4681 has been merged, all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rashansmith
Copy link

Hi @SergeyKanzhelev,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@Princesso
Copy link

Hi @SergeyKanzhelev, gentle reminder to raise a draft doc PR against dev-1.31 for this enhancement, before Thursday, June 27, 2024, 18:00 PDT.

@rashansmith
Copy link

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@SergeyKanzhelev
Copy link
Member Author

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

@rashansmith
Copy link

Hello @SergeyKanzhelev,

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, you currently have a PR for a docs change. To submit a blog post placeholder, create a PR on The website blogpost directory. Here is an example PR. Let me know if you have any questions!

@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Jul 8, 2024

Hey again @SergeyKanzhelev 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Regarding this enhancement, it appears that there are currently no open pull requests in the k/k repository related to it.

For this KEP, we would need to do the following:

  • Ensure all PRs to the Kubernetes repo related to your enhancement are linked in the above issue description (for tracking purposes).
  • Ensure all PRs are prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Jul 21, 2024

Hey again @SergeyKanzhelev 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment #4680 (comment) still need to be completed. The following PR as per the description still needs to be merged:

If you anticipate missing code freeze, you can file an exception request in advance.

@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Jul 23, 2024

Note for self to add to the beta graduation requirements: kubernetes/kubernetes#126243 (comment)

Potential code change to improve stress behavior: https://github.com/kubernetes/kubernetes/pull/126243/files#r1688457694

@sreeram-venkitesh
Copy link
Member

@SergeyKanzhelev KEP has been tracked for code freeze after kubernetes/kubernetes#126243 is merged 🎉

@drewhagen
Copy link
Member

drewhagen commented Jul 24, 2024

Hello @SergeyKanzhelev,
Awesome job on passing code freeze.

I'm immediately switching to ⚠️Risk for Doc Freeze because it is very overdue to have documentation ready to review. (the deadline was last week, Tuesday, July 16th, 2024 18:00 PST and the diff on the website PR only has "TODO" in it) SIG Release Docs has reached out but we haven't heard a response. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ASAP.

❗️This is important because the next deadline is the Doc Freeze on Tuesday 30th July 2024, after which will require an approved exception for this feature to ship with 1.31 if docs aren't merged. We appreciate your prompt attention to getting these docs ready for review, because with that review, SIG Docs will need to review and approve per project standards, along with a technical review from your SIG. Any suggested changes must be addressed, reviewed again, approved, and merged. SIG Release is available to help facilitate these activities but there's limited time left!

Thanks for your cooperation. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Doc Freeze
Development

No branches or pull requests

10 participants