-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VolumeSource: OCI Artifact and/or Image #4639
Comments
I've had informal discussions about this - there's enough interest IMO to open a KEP & I will present this issue at upcoming sig-node, sig-storage mtgs with a KEP draft /sig node |
Can you use the Volume Populator? It allows you to create a PVC from an extenal data source. https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1495-volume-populators |
Happy to support here from a SIG node perspective. cc @kubernetes/sig-node-proposals |
+1 happy to help from the SIG-Node/CRI and OCI image/distribution spec perspectives.. |
/label lead-opted-in as discussed at SIG Node meeting this week, we will try and see if this can make it to 1.31 |
/stage alpha |
For reference, in KServe a workaround for directly accessing files within an OCI image is currently implemented and available via a sidecar approach ("modelcar") by leveraging root FS system access via the So KServe would be more than happy to leverage such a volume type, and we are happy to support any efforts in this direction. |
/stage alpha |
Hello @sallyom 👋, v1.31 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, most of the above items are taken care of in #4642. We'd need to do the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you! |
@sallyom Pinging once again as a slight reminder that we're approaching the enhancements freeze deadline on 14th June, this Friday! |
Hi @sallyom @SergeyKanzhelev 👋, 1.31 Enhancements team here, Just a quick friendly reminder as we approach the enhancements freeze in few hours, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024. The current status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hello @sallyom @SergeyKanzhelev 👋, 1.31 Enhancements team here. Unfortunately, this enhancement did not meet requirements for enhancements freeze. If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! |
/milestone clear |
/assign |
Marked as |
Hello @bitoku, @sallyom 👋, 1.31 Docs Lead here. |
Hi @saschagrunert , @sallyom 👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines. Note: In your placeholder PR, use |
@hailkomputer thank you for the hint, I added a placeholder PR in kubernetes/website#46960 |
@saschagrunert Do you know where the |
I would assume that we have no implementation right now for containerd. @mikebrow may provide more details on that. |
Hey again @saschagrunert @sallyom 👋 v1.31 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024. Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):
Out of tree:
If you anticipate missing code freeze, you can file an exception request in advance. I'm marking this KEP as |
/milestone v1.31 |
Hi again @sallyom @saschagrunert! We are one week away from code freeze and I wanted to ping you here as a friendly reminder for making sure the code PRs are merged in time before the deadline. Also, please let me know if there are any more PRs that needs to be tracked other than the ones linked in #4639 (comment). Thanks! |
@sallyom @saschagrunert All the PRs mentioned in #4639 (comment) are merged. Are we waiting for cri-o/cri-o#8408 and kubernetes/kubernetes#126220 to be merged as part of this KEP too? Please let me know! |
@sreeram-venkitesh we're now actively working on the docs, the implementation is done and everything which is still open is nice to have. Out of tree PR's are not a requirement for this KEP. |
Thanks @saschagrunert! Marking this KEP as |
The PR kubernetes/kubernetes#126220 which adds tests is still open. Please make sure to get it merged by the test freeze deadline (01:00 UTC Wednesday 31st July 2024 / 19:00 PDT Tuesday 30th July 2024). |
@saschagrunert FYI: This is the issue for containerd to support this KEP. |
@utam0k thank you for tracking the enhancement into containerd. Let me know if you need anything as support! |
Hi everyone. Are there plans to support subPath or (better) projected volumes for OCI VolumeSource? I have multiple (10+) ML models and would like to be able to mount them in one place:
|
@asviel maybe in some later graduation of the feature. Thank you for the input here! |
Hello Everyone, I have tried and getting below error- pod.yaml
|
@deepforu47 please open an issue in https://github.com/kubernetes/kubernetes. I assume you're using containerd? Right now only CRI-O |
Sure @saschagrunert will open new issue. New Error -
|
@deepforu47 @saschagrunert FYI for tracking wip pr for containerd v2 release candidate: containerd/containerd#10579 |
Enhancement Description
k/enhancements
) update PR(s): KEP-4639: adding OCI VolumeSource #4642k/k
) update PR(s):ImageVolumeSource
API kubernetes#125660ImageVolumeSource
implementation kubernetes#125663fsGroupChangePolicy
has no effect kubernetes#126281CanSupport
method kubernetes#126323ImageVolumeSource
node e2e tests kubernetes#126220crictl [create|run] --with-pull
kubernetes-sigs/cri-tools#1464pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e
test job test-infra#33071k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: