Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow anonymous auth for configured endpoints. #4633

Open
9 of 13 tasks
vinayakankugoyal opened this issue May 13, 2024 · 21 comments
Open
9 of 13 tasks

Only allow anonymous auth for configured endpoints. #4633

vinayakankugoyal opened this issue May 13, 2024 · 21 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@vinayakankugoyal
Copy link
Contributor

vinayakankugoyal commented May 13, 2024

Enhancement Description

Allow users to specify which endpoints are allowed for anonymous requests. This allows the admin to only allow access to health endpoints like healthz, livez and readyz anonymously while making sure other cluster endpoints or resources cannot be access anonymously even if a user misconfigures RBAC.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 13, 2024
@vinayakankugoyal vinayakankugoyal changed the title Only allow anonymous auth for healthz. Only allow anonymous auth for health endpoints. May 13, 2024
@vinayakankugoyal
Copy link
Contributor Author

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2024
@vinayakankugoyal
Copy link
Contributor Author

/cc @liggitt @destijl

@vinayakankugoyal
Copy link
Contributor Author

/milestone v1.31

@k8s-ci-robot
Copy link
Contributor

@vinayakankugoyal: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liggitt
Copy link
Member

liggitt commented May 15, 2024

/milestone v1.31
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 15, 2024
@liggitt liggitt added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 15, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 15, 2024
@vinayakankugoyal
Copy link
Contributor Author

PRR Approver

/assign @jpbetz

@sftim
Copy link
Contributor

sftim commented May 24, 2024

/retitle Only allow anonymous auth for health endpoints

@k8s-ci-robot k8s-ci-robot changed the title Only allow anonymous auth for health endpoints. Only allow anonymous auth for health endpoints May 24, 2024
@vinayakankugoyal vinayakankugoyal changed the title Only allow anonymous auth for health endpoints Only allow anonymous auth for configured endpoints. May 24, 2024
@prianna
Copy link

prianna commented Jun 4, 2024

Hello @vinayakankugoyal 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline of Thursday 6th June 2024 so that the PRR team has enough time to review your KEP.

For this KEP, it looks like we still need to do the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@vinayakankugoyal
Copy link
Contributor Author

Hi @prianna - thanks a lot for the heads up. We were granted the PRR approval #4634 (comment) and the reviewers have agreed that we can set the status to implementable. I am expecting this to be merged this week.

@vinayakankugoyal
Copy link
Contributor Author

@prianna - The KEP was merged as implementable in milestone 1.31 with a PRR approval. Are we all good on the KEP freeze front?

@MaryamTavakkoli
Copy link

Hello @jpbetz @liggitt @vinayakankugoyal 👋, 1.31 Docs Shadow here.
Does this enhancement work planned for 1.31 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, June 27, 2024, 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

@prianna
Copy link

prianna commented Jun 12, 2024

Hey folks, with the merge of #4634, here's where this KEP currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@a-mccarthy
Copy link

Hi @jpbetz @liggitt @vinayakankugoyal 👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@Princesso
Copy link

Princesso commented Jun 23, 2024

Hello @jpbetz @liggitt @vinayakankugoyal 👋, 1.31 Docs Shadow here. Does this enhancement work planned for 1.31 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, June 27, 2024, 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

Hi @jpbetz @liggitt @vinayakankugoyal, gentle reminder to raise a draft doc PR before the Placeholder PR deadline, scheduled for June 27, 2024.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@MaryamTavakkoli
Copy link

Hi @jpbetz @liggitt @vinayakankugoyal, This is a friendly reminder that the deadline for the draft Doc PR is tomorrow, Thursday, June 27, 2024, 18:00 PDT.

@vinayakankugoyal
Copy link
Contributor Author

@MaryamTavakkoli - thanks opened a draft PR here: kubernetes/website#46988

@a-mccarthy
Copy link

Hello @vinayakankugoyal @jpbetz @liggitt, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@prianna
Copy link

prianna commented Jul 9, 2024

Hey again @vinayakankugoyal 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@vinayakankugoyal
Copy link
Contributor Author

Thanks @prianna! kubernetes/kubernetes#125967 is the only remaining action item for this KEP. I am just waiting for someone from sig-auth to Approve.

Other than that the docs PR kubernetes/website#46988 is also waiting for review and approval.

@prianna
Copy link

prianna commented Jul 17, 2024

Looks like this was merged. With the merge of kubernetes/kubernetes#125967 as per the issue, this enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

@liggitt liggitt modified the milestones: v1.31, v1.32 Aug 20, 2024
@liggitt liggitt added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Aug 20, 2024
@liggitt
Copy link
Member

liggitt commented Aug 20, 2024

opting in for beta for 1.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Doc Freeze
Status: In Review
Development

No branches or pull requests

10 participants