Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add drain node endpoint #9465

Merged
merged 7 commits into from
Sep 13, 2024
Merged

feat: Add drain node endpoint #9465

merged 7 commits into from
Sep 13, 2024

Conversation

maciaszczykm
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
@maciaszczykm maciaszczykm added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.71429% with 50 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (a12c809) to head (cdf3fc6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9465      +/-   ##
==========================================
- Coverage   37.22%   37.08%   -0.15%     
==========================================
  Files         255      256       +1     
  Lines       11197    11253      +56     
  Branches      157      158       +1     
==========================================
+ Hits         4168     4173       +5     
- Misses       6772     6861      +89     
+ Partials      257      219      -38

@maciaszczykm maciaszczykm marked this pull request as ready for review September 13, 2024 07:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm maciaszczykm merged commit 5fcb7f8 into master Sep 13, 2024
16 of 17 checks passed
@maciaszczykm maciaszczykm deleted the drain-node branch September 13, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciaszczykm @k8s-ci-robot @floreks