Implements frontend for deployment rollback

[shu-mutou]

History list is added into deployment detail view, and Rollback action is added in each row except for current revision.

Fixes: #2889

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #6003 (9b3d50f) into master (d3b1a14) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #6003      +/-   ##
==========================================
+ Coverage   41.89%   41.95%   +0.06%     
==========================================
  Files          44       44              
  Lines        1234     1237       +3     
  Branches      163      163              
==========================================
+ Hits          517      519       +2     
- Misses        717      718       +1     

[shu-mutou]

/hold
This would conflict with #6005. Wait for merging it.

[shu-mutou]

/hold cancel

[floreks]

This kind of breaks our pattern of resource being a Kubernetes resource. It is then used in the frontend as a resource also. I'd have to rethink how to incorporate that into our patterns.

[shu-mutou]

Yes, these are defined in frontend also.
To create dialog contents and submission endpoint URL, the action on history row needed to pass deployment name and namespace to dialog. So I defined new type History that have ReplicaSet and parent resource information. Could you let me know if you have better idea about this?

[floreks]

I'll think about how we could add this without breaking our patterns. Resource should be mappable to a real Kubernetes resource. History/HistoryList is a very abstract thing.

[floreks]

I was on vacation last week. I'll try to take a look at it this week.

[romdhanisam]

Hello, why You don't using Redux, it's very important in a project like kubernetes UI.

[floreks]

It's not important. It's a matter of personal preference. Also, PR is not a good place to discuss such things.

[shu-mutou]

@maciaszczykm @floreks PTAL again. Thanks!!

[k8s-ci-robot]

@shu-mutou: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floreks]

Since #7047 has been merged and it introduces major architecture changes we should close this PR. If you are willing to work on it, you can open a new PR against the current master.

/close

[k8s-ci-robot]

@floreks: Closed this PR.

In response to this:

Since #7047 has been merged and it introduces major architecture changes we should close this PR. If you are willing to work on it, you can open a new PR against the current master.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.