Updating the generator docs to match current functionality #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
Hey @mattfarina.. thanks for pointing this out. That's confusing an unintended. I've put in a fix here (#1127) that should fix up the functionality, and the docs too. |
|
I prefer the fix in #1127. So, closing. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 26, 2017
Automatic merge from submit-queue. . Update generator to use WHAT variable Having to set two different variables is confusing. Changed this to look at the `WHAT` envvar and match on a suffix. Fixes #1126. cc: @jamiehannaford
danehans
pushed a commit
to danehans/community
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the Makefile had changed at some point. This updates the docs to reflect the change.