Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add support for klog levels #291

Closed
wants to merge 1 commit into from
Closed

feat(cli): Add support for klog levels #291

wants to merge 1 commit into from

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Jan 20, 2024 •
edited
Loading

It would be helpful if klog dumps commands executed on remote node or details of dialled connection.

@mloskot
feat(cli): Add support for klog levels
2bce746 
It would be helpful if klog dumps commands executed
on remote node or details of dialed connection.

Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2024
@mloskot
Copy link
Contributor Author

mloskot commented Jan 21, 2024

I've learned on Slack #klog channel that is becoming a deprecated technology in Kubernetes:

Screenshot_20240121_172128_Slack.jpg

I will look into replacing uses of klog in SWDT CLI with the suggested alternative.

@mloskot mloskot mentioned this pull request Jan 26, 2024
Merged
@mloskot
Copy link
Contributor Author

mloskot commented Jan 26, 2024

Replaced by

@mloskot mloskot closed this Jan 26, 2024
@mloskot mloskot deleted the ml/swdt-cli-add-verbose-logging branch January 26, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp Awaiting requested review from aravindhp

@knabben knabben Awaiting requested review from knabben

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mloskot @k8s-ci-robot