http agent: Properly wrap buffer reading error #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This PR properly wraps errors when reading HTTP responses in the agent so that the error code can
by communicated downstream.
This should fix the ci-fast-forward job by wiring the 404 response code to the release gcb package:
https://github.com/kubernetes/release/blob/367414ceffffa3f97896b8c5a78df55f072ff303/pkg/gcp/gcb/gcb.go#L400-L402
Thanks @dims and @cpanato for investigating it
Which issue(s) this PR fixes:
Fixes the
ci-fast-forward
jobSpecial notes for your reviewer:
Does this PR introduce a user-facing change?