Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial admission #771

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Partial admission #771

merged 8 commits into from
Jun 7, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented May 15, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds support for partial workload admission.

Which issue(s) this PR fixes:

Fixes #420

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add support for partial workload admission

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2023
@netlify
Copy link

netlify bot commented May 15, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 79be7c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/648025d37acd6400082576b5

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2023
@trasc trasc force-pushed the partial-admission branch 2 times, most recently from 7297247 to 50aae9b Compare May 17, 2023 09:19
@trasc trasc marked this pull request as ready for review May 17, 2023 09:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2023
@trasc
Copy link
Contributor Author

trasc commented May 17, 2023

/cc @alculquicondor

@tenzen-y
Copy link
Member

I queued this PR to my tomorrow review queue.

@alculquicondor alculquicondor mentioned this pull request May 19, 2023
Closed
alculquicondor
alculquicondor reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this implementation covers all use cases. See my comment in the flavor assigner.

apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_webhook.go Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Outdated Show resolved Hide resolved
@trasc trasc force-pushed the partial-admission branch 3 times, most recently from 7e0c655 to bbea05b Compare May 25, 2023 14:54
alculquicondor
alculquicondor reviewed May 26, 2023
View reviewed changes
pkg/controller/jobs/job/job_webhook.go Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Show resolved Hide resolved
pkg/scheduler/flavorassigner/podSetReducer.go Outdated Show resolved Hide resolved
pkg/util/slice/slice.go Outdated Show resolved Hide resolved
pkg/util/testingjobs/job/wrappers.go Show resolved Hide resolved
test/integration/controller/job/job_controller_test.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Show resolved Hide resolved
pkg/scheduler/preemption/preemption.go Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

I didn't review scheduler, preemption or flavor_assigner yet. I hope we can merge #806 first

@trasc trasc force-pushed the partial-admission branch 2 times, most recently from 5e4848d to d84fda9 Compare May 26, 2023 13:00
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@tenzen-y tenzen-y mentioned this pull request May 31, 2023
Open
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
alculquicondor
alculquicondor reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I'm looking for opportunities to simplify.
I think we might need to revert the annotation. Could you explore this possibility in a preparatory PR?

pkg/scheduler/flavorassigner/podset_reducer.go Outdated Show resolved Hide resolved
pkg/scheduler/flavorassigner/podset_reducer_test.go Show resolved Hide resolved
pkg/scheduler/flavorassigner/podset_reducer.go Show resolved Hide resolved
@trasc trasc force-pushed the partial-admission branch 2 times, most recently from bbb102b to 9d0a2be Compare June 6, 2023 11:43
alculquicondor
alculquicondor reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Just final nits

Please adjust the release note to indicate that this is specific to Job.

pkg/features/kube_features.go Show resolved Hide resolved
pkg/scheduler/flavorassigner/podset_reducer.go Outdated Show resolved Hide resolved
pkg/webhooks/workload_webhook.go Outdated Show resolved Hide resolved
pkg/webhooks/workload_webhook.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@trasc trasc mentioned this pull request Jun 7, 2023
Closed
3 tasks
@alculquicondor
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Contributor

/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7444b27 into kubernetes-sigs:main Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 7, 2023
@trasc trasc deleted the partial-admission branch June 9, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Allow partial admission of jobs
4 participants
@trasc @k8s-ci-robot @tenzen-y @alculquicondor