Enable to sort kube_control_plane including the first node #9756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @kerryeon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
HoKim98
force-pushed
the
raplace-first-kube-control-plane
branch
from
2874158
to
0f66334
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kerryeon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
requirements-$ANSIBLE_VERSION.yml doesn't exist in Kubespray repo. That was for supporting ansible 2.10-, and now Kubespray supports 2.11+. So this drops the part to avoid confusion.
crun_bin_dir was used to specify the destination of the crun binary during the download process. This path must match with the value provided in the CRI-O configuration file. So changing its value to bin_dir helps to mismatch errors. Signed-off-by: Victor Morales <chipahuac@hotmail.com>
* network_plugin/custom_cni: add CNI to apply provided manifests Add a new simple custom_cni to install provided Kubernetes manifests. This could be useful to use manifests directly provided by a CNI when there are not support by Kubespray (i.e.: helm chart or any other manifests generation method). Co-authored-by: James Landrein <james.landrein@proton.ch> Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * network_plugin/custom_cni: add test with cilium Co-authored-by: James Landrein <james.landrein@proton.ch> Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> Co-authored-by: James Landrein <james.landrein@proton.ch>
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
Signed-off-by: panguicai008 <1121906548@qq.com>
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
Signed-off-by: panguicai008 <1121906548@qq.com>
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
…kubernetes-sigs#9834) * node: fix default kubelet/runtime cgroups when kube_reserved is false (default) Commit 1c4db61 introduced a notion of kube_reserved. This introduced a breaking change defaulting to use kube.slice for the container_manager and the kubelet as if kube_reserved was always enabled whereas it is disabled by default. This commit fixes this by bringing back system.slice whenever kube_reserved is disabled. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * inventory/sample: change false for kube_reserved as its the default Changing the commented value in sample inventory to the actual default value. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: panguicai008 <1121906548@qq.com>
Signed-off-by: panguicai008 <1121906548@qq.com>
…kubernetes-sigs#9718) This commit removes the variable `use_localhost_as_kubeapi_loadbalancer` and rather detects that we are in a situation where we can use the localhost apiserver loadbalancer (meaning that we use the localhost load balancer and that the same ports are used for both the load balancer and the kube-apiserver). This also cleanups the calico code to use `kube_apiserver_global_endpoint` rather than implementing the same logic all over again. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
k8s-ci-robot
added
size/XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The first kubernetes control plane node has a very important role in overall kubespray workflows. However, if the first node is out of order with the others, the kubernetes cluster configuration will fail catastrophically. For example, certificate loss due to accidental ETCD and Kubernetes SSL key renewal.
Keeping the order of the first nodes is very important, but there is always the potential for human error to cause problems. So, I want to force the dynamic discovery logic to consider one of the kubernetes control plane nodes that are still functioning as the first node, so that we don't run into issues with node order in the first place.
Fortunately, I have been able to find that these attempts are already being made locally. Therefore, this PR will be a generalization of them. (#7989)
> BEFORE
> AFTER
kube_control_planeAnd if control planes are changed via
cluster.ymland etc, it will automatically update thecluster-infoto the first control plane node.> BUG FIXES
fallback_ips. The problem is that if all nodes do not have network adapters, the value offallback_ips_basebecomes"---", so the value offallback_ips, the result of yaml-parsing, becomes a str object. This bug occurs when testingmolecule_docker.Which issue(s) this PR fixes:
Fixes #3471 (only for
kube_control_plane)Special notes for your reviewer:
This PR has many changes for usage of
kube_control_plane | first.So many various tests are needed, but I can't be sure that this changes are complete yet, so I want to review with others.
Does this PR introduce a user-facing change?: