Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the ping package #9284

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Sep 16, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

On the ubuntu server 22.04 (min install), there need to install the ping package.

Which issue(s) this PR fixes:

Fixes #9283

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ensure ping package is installed on the system

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2022
@yankay
Copy link
Member Author

yankay commented Sep 16, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 16, 2022
@oomichi oomichi added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2022
@oomichi
Copy link
Contributor

oomichi commented Sep 20, 2022

Thanks for doing this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@yankay
Copy link
Member Author

yankay commented Sep 22, 2022

Thanks for doing this.

/lgtm

Thanks for the PR review :-)

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay Thank you
Shipping! 🚢 ...

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@floryut floryut mentioned this pull request Sep 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5d3326b into kubernetes-sigs:master Sep 22, 2022
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such file or directory: b'ping'
4 participants