Add variable for the vsphere-csi namespace

[MahdiAbbasi95]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

I've added a new variable for the vsphere-csi-namespace and all vsphere-csi manifest will be deploy on this namespace instead of "kube-system" namespace.
vsphere csi uses its own namespace that is "vmware-system-csi", but in the current version of kubespray in the deploying vsphere csi, the namespace is set to the kube-system, but it will be an issue for csi, because it wants to find "vmware-system-csi" namespace but it doesn't exist. the value should be fixed but I've added a variable with "vmware-system-csi" default value for flexibility.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Add variable to tweak the vsphere-csi namespace (`vsphere_csi_namespace`)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: MahdiAbbasi95 / name: Mahdi Abbasi (51701cb)

[k8s-ci-robot]

Welcome @MahdiAbbasi95!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MahdiAbbasi95. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@MahdiAbbasi95 Thanks 👍
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MahdiAbbasi95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

/lgtm

[fungusakafungus]

I think this does introduce a user-facing change, it deploys vsphere-csi stuff a second time into the new default namespace of vmware-system-csi if the new variable is not touched. I suggest to leave the default on kube-system.

[MahdiAbbasi95]

I think this does introduce a user-facing change, it deploys vsphere-csi stuff a second time into the new default namespace of vmware-system-csi if the new variable is not touched. I suggest to leave the default on kube-system.

You are right about the user-facing change, but as I explained deploying the vsphere-csi on the kube-system is not correct anyway and has various issues and because of that I think we should leave the default on the right namespace (vmware-system-csi)

[floryut]

I think this does introduce a user-facing change, it deploys vsphere-csi stuff a second time into the new default namespace of vmware-system-csi if the new variable is not touched. I suggest to leave the default on kube-system.

Oops, I agree we missed that, @MahdiAbbasi95 for this version we should keep the default as kube-system, and warn user that this might change.