Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd] Sometimes, we do not need to run etcd role on all nodes. #9173

Merged
merged 3 commits into from
Sep 9, 2022
Merged

[etcd] Sometimes, we do not need to run etcd role on all nodes. #9173

merged 3 commits into from
Sep 9, 2022

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented Aug 13, 2022 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Some plugins, we do not need to run etcd role on all nodes.

It only needs to be run at the etcd node and the control node.

similar kubeadm-etcd:

kubespray/roles/kubernetes/kubeadm/tasks/main.yml

Lines 155 to 161 in 8585134

- name: Extract etcd certs from control plane if using etcd kubeadm mode
include_tasks: kubeadm_etcd_node.yml
when:
- etcd_deployment_type == "kubeadm"
- inventory_hostname not in groups['kube_control_plane']
- kube_network_plugin in ["calico", "flannel", "canal", "cilium"] or cilium_deploy_additionally | default(false) | bool
- kube_network_plugin != "calico" or calico_datastore == "etcd"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[etcd] Etcd role won't run on all nodes everytime.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2022
@liupeng0518 liupeng0518 changed the title WIP: sometimes,we not run etcd WIP: sometimes, we do not need to run etcd role on all nodes. Aug 13, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2022
@liupeng0518 liupeng0518 changed the title WIP: sometimes, we do not need to run etcd role on all nodes. Sometimes, we do not need to run etcd role on all nodes. Aug 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2022
@liupeng0518 liupeng0518 changed the title Sometimes, we do not need to run etcd role on all nodes. [etcd] Sometimes, we do not need to run etcd role on all nodes. Aug 15, 2022
@cristicalin
Copy link
Contributor

Nice cleanup/speedup @liupeng0518

/kind feature
/approve

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, liupeng0518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
@cristicalin
Copy link
Contributor

Hi @liupeng0518, please rebase this PR on the current state of the master branch to be able to pass the CI tests.

@jayonlau
Copy link
Contributor

jayonlau commented Sep 8, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jayonlau: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayonlau
Copy link
Contributor

jayonlau commented Sep 8, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jayonlau: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayonlau
Copy link
Contributor

jayonlau commented Sep 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@liupeng0518
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@liupeng0518: The following commands are available to trigger required jobs:

  • /test pull-kubespray-yamllint

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liupeng0518
Copy link
Member Author

/test all

@k8s-ci-robot k8s-ci-robot merged commit dd4bc5f into kubernetes-sigs:master Sep 9, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@liupeng0518 @enneitex
[etcd] Sometimes, we do not need to run etcd role on all nodes. (kube…
57f2607 
…rnetes-sigs#9173)

* WIP: sometimes,we not run etcd

* fix ansible lint

* like calico(kdd) cni, no need run etcd
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@liupeng0518 @nolimitkun
[etcd] Sometimes, we do not need to run etcd role on all nodes. (kube…
6da706d 
…rnetes-sigs#9173)

* WIP: sometimes,we not run etcd

* fix ansible lint

* like calico(kdd) cni, no need run etcd
@2k0ri 2k0ri mentioned this pull request Apr 12, 2023
Merged
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@liupeng0518 @LuckySB
[etcd] Sometimes, we do not need to run etcd role on all nodes. (kube…
e805537 
…rnetes-sigs#9173)

* WIP: sometimes,we not run etcd

* fix ansible lint

* like calico(kdd) cni, no need run etcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@jayonlau jayonlau

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liupeng0518 @cristicalin @k8s-ci-robot @jayonlau