Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kube-vip check to check_readme_versions.sh #9155

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Aug 6, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To check the kube-vip version between readme.md and the default value on the role, this updates check_readme_versions.sh

Does this PR introduce a user-facing change?:

NONE

To check the kube-vip version between readme.md and the default value
on the role, this updates check_readme_versions.sh
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bozzo August 6, 2022 01:08
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2022
@cristicalin
Copy link
Contributor

Thanks @oomichi

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7e86293 into kubernetes-sigs:master Aug 6, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
To check the kube-vip version between readme.md and the default value
on the role, this updates check_readme_versions.sh
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
To check the kube-vip version between readme.md and the default value
on the role, this updates check_readme_versions.sh
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
To check the kube-vip version between readme.md and the default value
on the role, this updates check_readme_versions.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants