Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pid reserved must be str #9124

Merged
merged 1 commit into from
Jul 31, 2022
Merged

pid reserved must be str #9124

merged 1 commit into from
Jul 31, 2022

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented Jul 27, 2022 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Variable `kube_pid_reserved` must be a string

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bozzo July 27, 2022 09:00
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2022
floryut
floryut approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liupeng0518 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, liupeng0518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@oomichi
Copy link
Contributor

oomichi commented Jul 31, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit e73803c into kubernetes-sigs:master Jul 31, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@liupeng0518 @nolimitkun
pid reserved must be str (kubernetes-sigs#9124)
eb40e3d
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
@liupeng0518 @LuckySB
pid reserved must be str (kubernetes-sigs#9124)
5b63de5
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@liupeng0518 @LuckySB
pid reserved must be str (kubernetes-sigs#9124)
98a92ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liupeng0518 @k8s-ci-robot @oomichi @floryut