Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardening: Add SeccompDefault admission plugin for kubelet #9074

Merged
merged 3 commits into from
Jul 19, 2022
Merged

hardening: Add SeccompDefault admission plugin for kubelet #9074

merged 3 commits into from
Jul 19, 2022

Conversation

alegrey91
Copy link
Contributor

@alegrey91 alegrey91 commented Jul 7, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add kubelet configuration to set default seccomp profile on pods.
This can improve security of the cluster, by providing documentation and examples about it.

Which issue(s) this PR fixes:

Fixes #9073

Does this PR introduce a user-facing change?:

Add `SeccompDefault` admission plugin for kubelet (using new variable `kubelet_seccomp_default`)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alegrey91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2022
@alegrey91 alegrey91 changed the title WIP: docs(hardening): add SeccompDefault admission plugin kubelet hardening: Add SeccompDefault admission plugin for kubelet Jul 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2022
@alegrey91 alegrey91 changed the title hardening: Add SeccompDefault admission plugin for kubelet hardening: Add SeccompDefault admission plugin for kubelet Jul 12, 2022
@mzaian
Copy link
Contributor

mzaian commented Jul 12, 2022

@alegrey91 This featuregate is still in alpha stage. Why would it be enabled?

@alegrey91
Copy link
Contributor Author

Hi @mzaian.
This is not enabled by default (in kubespray).
I just provided the code and the documentation to enable it (in case the user wants to).

@oomichi
Copy link
Contributor

oomichi commented Jul 12, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
floryut
floryut approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alegrey91 Great 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegrey91, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3ce5458 into kubernetes-sigs:master Jul 19, 2022
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Jul 19, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@alegrey91 @nolimitkun
hardening: Add SeccompDefault admission plugin for kubelet (kuberne…
f5395b2 
…tes-sigs#9074)

* docs(hardening): add SeccompDefault admission plugin to kubelet feature gates

* fix(kubelet-config): enable config through kubelet_feature_gates

* feat(kubelet): add kubelet_seccomp_default variable
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
@alegrey91 @LuckySB
hardening: Add SeccompDefault admission plugin for kubelet (kuberne…
49bcdfa 
…tes-sigs#9074)

* docs(hardening): add SeccompDefault admission plugin to kubelet feature gates

* fix(kubelet-config): enable config through kubelet_feature_gates

* feat(kubelet): add kubelet_seccomp_default variable
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@alegrey91 @LuckySB
hardening: Add SeccompDefault admission plugin for kubelet (kuberne…
0049da2 
…tes-sigs#9074)

* docs(hardening): add SeccompDefault admission plugin to kubelet feature gates

* fix(kubelet-config): enable config through kubelet_feature_gates

* feat(kubelet): add kubelet_seccomp_default variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SeccompDefault admission plugin to hardening guide
5 participants
@alegrey91 @k8s-ci-robot @mzaian @oomichi @floryut