-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade cilium and add default variables #9065
Conversation
Hi @eminaktas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6d3974b
to
491d47d
Compare
/cc @necatican |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes overall!
I have two little suggestions.
Thank you for your contribution ❤️
roles/network_plugin/cilium/templates/cilium-operator/deploy.yml.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: Emin Aktas <emin.aktas@trendyol.com>
/approve Thank you for the changes 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@eminaktas Thanks for the work 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eminaktas, floryut, necatican The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: Emin Aktas <emin.aktas@trendyol.com>
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: Emin Aktas <emin.aktas@trendyol.com>
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: Emin Aktas <emin.aktas@trendyol.com>
As you all know that cilium is growing rapidly and getting lots of updates. This PR aims to add some of the default variables and update the templates. With these changes, users can easily enable BPF for Cilium.
To enable BPF:
With the new releases, the cilium agent has an initContainer for cgroup auto-mount which is implemented and enabled by default.
Version is upgraded to 1.11.6
Signed-off-by: eminaktas eminaktas34@gmail.com
Signed-off-by: Emin Aktas emin.aktas@trendyol.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: NONE