Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase ansible fact_caching_timeout #9059

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

rptaylor
Copy link
Contributor

@rptaylor rptaylor commented Jul 5, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:
Kubespray plays can be very slow on large clusters. It can often take ~ 2-4 hours on clusters with ~100-200 nodes. (See timing measurements mentioned in #8050 ) The fact cache timeout is only 2 hours so the facts may have expired by the time a play finishes running, so then if you have to retry and run another play, it will be slower too because the facts need to be regathered again. Not only that, if the ansible_default_ipv4 fact is missing, the play gets even slower still, because then https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/tasks/fallback_ips.yml runs a task on every node in the cluster , even if you have used --limit. This happened when I ran scale.yml.

Special notes for your reviewer:
Actually I don't see why the facts should expire anyway. Maybe the timeout should be 0.

Does this PR introduce a user-facing change?:

Increase ansible fact_caching_timeout (from 2 to 24 hours)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rptaylor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022
@cristicalin
Copy link
Contributor

Thanks @rptaylor !

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@floryut floryut added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 6, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@rptaylor 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, rptaylor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 01c6239 into kubernetes-sigs:master Jul 6, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@rptaylor rptaylor deleted the patch-2 branch July 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants