add calico-kube-controllers missing verbs

[ghostloda]

What type of PR is this?

/kind bug

What this PR does / why we need it:
calico:v3.23.1
I found calico-kube-controllers pod start error,log show Failed to create watcher，clusterinformations and ippools is forbidden
so we need add watch and list ClusterRole

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add calico-kube-controllers missing verbs

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ghostloda / name: 忘尘 (09376bb)

[k8s-ci-robot]

Welcome @ghostloda!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ghostloda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Looks like upstream (https://projectcalico.docs.tigera.io/manifests/calico.yaml) separated the ippools and ipreservations and only granted watch on ipreservations`; please check against the upstream manifest and align with it.

[ghostloda]

thanks for your reviewed ，I checked the upstream manifest，the ippools and ipreservations is separated ， list on ipreservations and list watch on ippools

[ghostloda]

I have changed the code，it is my first pr and sorry for my poor english.

[ghostloda]

/assign @cristicalin

[oomichi]

Thanks for updating the manifest for the upstream one.

/lgtm

[oomichi]

forgot to put

/ok-to-test

😅

[floryut]

@ghostloda Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, ghostloda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ghostloda]

I found the bug in the 2.19,Do I need to create another pr merge to 2.19? not just the master. @floryut

[floryut]

I found the bug in the 2.19,Do I need to create another pr merge to 2.19? not just the master. @floryut

It could be backported to 2.19 indeed yes.