-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vsphere-csi] fix support for vsphere 6.7U3 #8944
Conversation
|
Welcome @snowball77! |
Hi @snowball77. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
53e2403
to
a12e8f7
Compare
/retitle [vsphere-csi] fix support for vsphere 6.7U3 |
Proposed fix to Issue 8667 Proposed fix to Issue 8667
Btw. a reference to the issue related to csi auth on 6.7u3: kubernetes-sigs/vsphere-csi-driver#723 |
Thanks for this @snowball77 ! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you @snowball77
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, snowball77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed fix to Issue 8667 Proposed fix to Issue 8667
Proposed fix to Issue 8667 Proposed fix to Issue 8667
Proposed fix to Issue 8667 Proposed fix to Issue 8667
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8667
Special notes for your reviewer:
Fixes vSphere CSI on old vSphere installations. This obviously has not been tested in the past and did not work the way it was implemented. Patch proposes needed fixes and also proposes to update the sample inventory file to the latest vSphere CSI which I used for testing in my environment.
Does this PR introduce a user-facing change?: