Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vsphere-csi] fix support for vsphere 6.7U3 #8944

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

snowball77
Copy link
Contributor

@snowball77 snowball77 commented Jun 8, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8667

Special notes for your reviewer:
Fixes vSphere CSI on old vSphere installations. This obviously has not been tested in the past and did not work the way it was implemented. Patch proposes needed fixes and also proposes to update the sample inventory file to the latest vSphere CSI which I used for testing in my environment.

Does this PR introduce a user-facing change?:

Fixes vSphere CSI for vSphere CSI >= 2.4.0 on vSphere 6.7U3

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 8, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: snowball77 / name: Steffen Becker (a12e8f7)

@k8s-ci-robot
Copy link
Contributor

Welcome @snowball77!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @snowball77. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2022
@snowball77 snowball77 force-pushed the issue/8667 branch 2 times, most recently from 53e2403 to a12e8f7 Compare June 8, 2022 01:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 8, 2022
@cristicalin
Copy link
Contributor

/retitle [vsphere-csi] fix support for vsphere 6.7U3

@k8s-ci-robot k8s-ci-robot changed the title Proposed fix for Issue #8667 [vsphere-csi] fix support for vsphere 6.7U3 Jun 8, 2022
Proposed fix to Issue 8667

Proposed fix to Issue 8667
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@snowball77
Copy link
Contributor Author

Btw. a reference to the issue related to csi auth on 6.7u3: kubernetes-sigs/vsphere-csi-driver#723

@cristicalin
Copy link
Contributor

Thanks for this @snowball77 !

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @snowball77

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, snowball77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b43d6a into kubernetes-sigs:master Jun 10, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
Proposed fix to Issue 8667

Proposed fix to Issue 8667
@floryut floryut mentioned this pull request Sep 19, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
Proposed fix to Issue 8667

Proposed fix to Issue 8667
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Proposed fix to Issue 8667

Proposed fix to Issue 8667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy vSphere external cloud provider: failed to create CSINodeTopology CRD
4 participants